FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix -Wunused-variable compiler warning by bnoordhuis · Pull Request #6129 · nodejs/node · GitHub

/ node Public

src: fix -Wunused-variable compiler warning - #6129

Merged
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix-unused-variable-warning
Apr 9, 2016
ConversationCommits (1)ChecksFiles changed
Merged

src: fix -Wunused-variable compiler warning#6129
bnoordhuis merged 1 commit into
nodejs:masterfrom
bnoordhuis:fix-unused-variable-warning

Conversation

bnoordhuis commented Apr 9, 2016

Copy link
Copy Markdown
Member

No description provided.

evanlucas commented Apr 9, 2016

Copy link
Copy Markdown
Contributor

LGTM

src: fix -Wunused-variable compiler warning
f938ef7 
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check
to JS".

PR-URL: nodejs#6129
Reviewed-By: Evan Lucas <evanlucas@me.com>
bnoordhuis force-pushed the fix-unused-variable-warning branch from 79c5e65 to f938ef7 Compare April 9, 2016 11:07
bnoordhuis closed this Apr 9, 2016
bnoordhuis deleted the fix-unused-variable-warning branch April 9, 2016 11:07
bnoordhuis merged commit f938ef7 into nodejs:master Apr 9, 2016
MylesBorins mentioned this pull request Apr 11, 2016
Closed

MylesBorins commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis lts?

bnoordhuis commented Apr 11, 2016

Copy link
Copy Markdown
Member Author

No. It was introduced by #5834 which is marked dont-land-on-v4.x. I'll add the labels here as well.

MylesBorins commented Apr 11, 2016

Copy link
Copy Markdown
Contributor

@bnoordhuis thanks

This was referenced May 17, 2016
Merged
Merged
evanlucas pushed a commit that referenced this pull request May 17, 2016
src: fix -Wunused-variable compiler warning
316871f 
Introduced in commit 7d8882b, "handle_wrap: expose an `isRefed()` check
to JS".

PR-URL: #6129
Reviewed-By: Evan Lucas <evanlucas@me.com>
evanlucas mentioned this pull request May 17, 2016
Merged
Fishrock123 mentioned this pull request May 19, 2016
Closed

MylesBorins commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

@Fishrock123 why was the dont-land label removed for v4?

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL