doc: reserve NMV 145 for Electron 41 - #61291
Merged
nodejs-github-bot merged 1 commit intoJan 7, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
approved these changes
Jan 5, 2026
richardlau
approved these changes
Jan 5, 2026
anonrig
approved these changes
Jan 6, 2026
UlisesGascon
approved these changes
Jan 6, 2026
avivkeller
approved these changes
Jan 6, 2026
cjihrig
approved these changes
Jan 6, 2026
lpinca
approved these changes
Jan 6, 2026
tniessen
approved these changes
Jan 7, 2026
Copy link
Copy Markdown
Contributor
Author
|
Thank you for all your reviews! Do I need to do anything else to get this merged? |
Sorry, something went wrong.
2 tasks
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61291 ✔ Done loading data for nodejs/node/pull/61291 ----------------------------------- PR info ------------------------------------ Title doc: reserve NMV 145 for Electron 41 (#61291) Author Niklas Wenzel <dev@nikwen.de> (@nikwen) Branch nikwen:nvm-electron-41 -> nodejs:main Labels doc, author ready, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 1 - doc: reserve NMV 145 for Electron 41 Committers 1 - Niklas Wenzel <dev@nikwen.de> PR-URL: https://github.com/nodejs/node/pull/61291 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61291 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 05 Jan 2026 22:30:22 GMT ✔ Approvals: 8 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3628671139 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3628738569 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3629250566 ✔ - Ulises Gascón (@UlisesGascon): https://github.com/nodejs/node/pull/61291#pullrequestreview-3629556786 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61291#pullrequestreview-3630579789 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61291#pullrequestreview-3630768130 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61291#pullrequestreview-3631746692 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/61291#pullrequestreview-3634379109 ⚠ This PR was merged on Wed, 07 Jan 2026 22:34:50 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/22325389744 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reserves NMV 145 for Electron 41. Thank you! 🙂
Relevant Electron task.