FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: move Quic dependencies behind ad-hoc flag by aduh95 · Pull Request #61446 · nodejs/node · GitHub

/ node Public

tools: move Quic dependencies behind ad-hoc flag - #61446

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:quic-compile-time-flag
Jan 27, 2026
ConversationCommits (1)ChecksFiles changed
Merged

tools: move Quic dependencies behind ad-hoc flag#61446
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
aduh95:quic-compile-time-flag

Conversation

aduh95 commented Jan 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refs: 853277a

aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 19, 2026

nodejs-github-bot commented Jan 19, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/startup

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 19, 2026
aduh95 removed the needs-ci PRs that need a full CI run. label Jan 19, 2026
avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jan 19, 2026

richardlau commented Jan 20, 2026

Copy link
Copy Markdown
Member

c1277d6 is from #61444, which should land first. Taking it to a separate PR as we can't backport Nix changes further than v25.x.

AFAIK the quic stuff has been mostly labelled dont-land-on-v24.x and earlier.

targos commented Jan 20, 2026

Copy link
Copy Markdown
Member

I was happy to see #61444 because QUIC has become a burden to maintain because of the lack of proper maintainers (at least to me because I had to fix things in it while I don't care about it).

This will make it worse as we will only see issues (and have to fix them) in GitHub CI.

targos commented Jan 20, 2026

Copy link
Copy Markdown
Member

My opinion is that while a feature is so much experimental (or unmaintained) that it has to be behind a build flag, we shouldn't put the burden of keeping it working to every contributor.

aduh95 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor Author

I wouldn't mind having the experimental removed from CI if we need to break it, it seems useful to be aware of when that happens though. In any case, I would still like to land the Nix changes marking QUIC deps as disabled by default.

tools: move Quic dependencies behind ad-hoc flag
86460e0 
Quic is now behind `--experimental-quic` build flag, its dependencies
should be included only if the user opts-in.
aduh95 force-pushed the quic-compile-time-flag branch from 88e8ed0 to 86460e0 Compare January 21, 2026 21:49
aduh95 changed the title tools: test building with --experimental-quic tools: move Quic dependencies behind ad-hoc flag Jan 21, 2026
aduh95 removed the blocked PRs that are blocked by other issues or PRs. label Jan 21, 2026

aduh95 commented Jan 21, 2026

Copy link
Copy Markdown
Contributor Author

Removed the test coverage since there was no consensus on it

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 22, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 27, 2026
nodejs-github-bot merged commit 150d154 into nodejs:main Jan 27, 2026
26 checks passed

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

Landed in 150d154

aduh95 deleted the quic-compile-time-flag branch January 27, 2026 22:21
aduh95 added a commit that referenced this pull request Jan 28, 2026
tools: move Quic dependencies behind ad-hoc flag
d5beb4f 
Quic is now behind `--experimental-quic` build flag, its dependencies
should be included only if the user opts-in.

PR-URL: #61446
Refs: 853277a
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 mentioned this pull request Jun 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL