FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add `cargo` and `rustc` checks for Temporal by richardlau · Pull Request #61467 · nodejs/node · GitHub

/ node Public

build: add cargo and rustc checks for Temporal - #61467

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:rust
Jan 24, 2026
Merged

build: add cargo and rustc checks for Temporal#61467
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:rust

Conversation

Copy link
Copy Markdown
Member

If opting into building Node.js with statically linked Temporal (configure --v8-enable-temporal-support), check for the presence of cargo and rustc and compare the detected versions against the documented toolchain versions in BUILDING.md.

Refs: #60942

If opting into building Node.js with statically linked Temporal
(`configure --v8-enable-temporal-support`), check for the presence
of `cargo` and `rustc` and compare the detected versions against the
documented toolchain versions in `BUILDING.md`.
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jan 22, 2026

This comment was marked as outdated.

This comment was marked as outdated.

juanarbol left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Amazing! Lgtm

Copy link
Copy Markdown
Collaborator

richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 22, 2026
richardlau added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 22, 2026
aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 22, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2026
nodejs-github-bot merged commit 159ae48 into nodejs:main Jan 24, 2026
88 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 159ae48

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL