FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: throw RangeError on failed ArrayBuffer BackingStore allocation by legendecas · Pull Request #61480 · nodejs/node · GitHub

/ node Public

src: throw RangeError on failed ArrayBuffer BackingStore allocation - #61480

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:arraybuffer-allocate
Jan 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

src: throw RangeError on failed ArrayBuffer BackingStore allocation#61480
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
legendecas:arraybuffer-allocate

Conversation

legendecas commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

This also updates ERR_MEMORY_ALLOCATION_FAILED to be a RangeError,
aligning with V8's OutOfMemory error type and ECMAScript's OutOfMemory
error type.

There are still many call sites in crypto, tls and quic need to be reviewed
to properly handle the failed ArrayBuffer BackingStore allocation. This
PR updates call sites not in these modules.

Refs:

node/deps/v8/src/builtins/builtins-typed-array.cc

Line 584 in c755b01

isolate, NewRangeError(MessageTemplate::kOutOfMemory,

Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Refs: #61403 (comment)

src: throw RangeError on failed ArrayBuffer BackingStore allocation
9326d89 
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError,
aligning with V8's OutOfMemory error type.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jan 22, 2026

codecov Bot commented Jan 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.86%. Comparing base (c755b01) to head (9326d89).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/node_buffer.cc 18.18% 15 Missing and 3 partials ⚠️
src/encoding_binding.cc 40.00% 2 Missing and 1 partial ⚠️
src/node_blob.cc 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61480      +/-   ##
==========================================
+ Coverage   89.85%   89.86%   +0.01%     
==========================================
  Files         665      665              
  Lines      203290   203309      +19     
  Branches    39081    39088       +7     
==========================================
+ Hits       182667   182710      +43     
+ Misses      12977    12945      -32     
- Partials     7646     7654       +8
Files with missing lines Coverage Δ
src/node_errors.h 84.84% <ø> (ø)
src/encoding_binding.cc 52.12% <40.00%> (-0.62%) ⬇️
src/node_blob.cc 74.93% <40.00%> (-1.11%) ⬇️
src/node_buffer.cc 67.89% <18.18%> (-0.73%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

addaleax approved these changes Jan 22, 2026
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you!

addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 22, 2026

nodejs-github-bot commented Jan 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70979/

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70982/

legendecas added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 25, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2026
nodejs-github-bot merged commit 3fed9fb into nodejs:main Jan 25, 2026
83 of 84 checks passed

nodejs-github-bot commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

Landed in 3fed9fb

legendecas deleted the arraybuffer-allocate branch January 25, 2026 15:48
aduh95 pushed a commit that referenced this pull request Jan 28, 2026
src: throw RangeError on failed ArrayBuffer BackingStore allocation
be644e2 
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError,
aligning with V8's OutOfMemory error type.

PR-URL: #61480
Refs: https://github.com/nodejs/node/blob/c755b0113ce0cb6d83baf2cf070ba381a5673db2/deps/v8/src/builtins/builtins-typed-array.cc#L584
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
src: throw RangeError on failed ArrayBuffer BackingStore allocation
6a7461a 
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError,
aligning with V8's OutOfMemory error type.

PR-URL: #61480
Refs: https://github.com/nodejs/node/blob/c755b0113ce0cb6d83baf2cf070ba381a5673db2/deps/v8/src/builtins/builtins-typed-array.cc#L584
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
src: throw RangeError on failed ArrayBuffer BackingStore allocation
da13186 
This also updates `ERR_MEMORY_ALLOCATION_FAILED` to be a RangeError,
aligning with V8's OutOfMemory error type.

PR-URL: #61480
Refs: https://github.com/nodejs/node/blob/c755b0113ce0cb6d83baf2cf070ba381a5673db2/deps/v8/src/builtins/builtins-typed-array.cc#L584
Refs: https://tc39.es/ecma262/#sec-sharedarraybuffer.prototype.grow
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere added a commit to electron/electron that referenced this pull request Feb 26, 2026
src: throw RangeError on failed ArrayBuffer BackingStore allocation
198616a 
nodejs/node#61480
jkleinsc pushed a commit to electron/electron that referenced this pull request Feb 26, 2026
chore: bump node to v24.14.0 (main) (#49941)
96ad701 
* chore: bump node in DEPS to v24.14.0

* lib: prefer call() over apply() if argument list is not array

nodejs/node#60796

* build,deps: replace cjs-module-lexer with merve

nodejs/node#61456

* chore: fixup patch indices

* test: use fixture directories for sea tests

nodejs/node#61167

* src: throw RangeError on failed ArrayBuffer BackingStore allocation

nodejs/node#61480

---------

Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com>
Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL