FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

process: do not truncate long strings in `--print` by mohd-akram · Pull Request #61497 · nodejs/node · GitHub

/ node Public

process: do not truncate long strings in --print - #61497

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mohd-akram:fix-print
Jan 25, 2026
ConversationCommits (1)ChecksFiles changed
Merged

process: do not truncate long strings in --print#61497
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
mohd-akram:fix-print

Conversation

mohd-akram commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Fixes: #61337

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

nodejs-github-bot added needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Jan 23, 2026
aduh95 previously approved these changes Jan 23, 2026
View reviewed changes
aduh95 reviewed Jan 23, 2026
View reviewed changes
Comment thread test/parallel/test-cli-print-promise.mjs Outdated
aduh95 dismissed their stale review January 23, 2026 22:18

outdated

aduh95 added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 23, 2026
aduh95 approved these changes Jan 23, 2026
View reviewed changes
Comment thread lib/internal/process/execution.js Outdated

aduh95 commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Any change you could update the commit message to e.g. process: do not truncate long strings in `--print`

aduh95 removed the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 23, 2026
mohd-akram changed the title process: fix output truncated process: do not truncate long strings in --print Jan 23, 2026

codecov Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (ec56413) to head (885f72b).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61497      +/-   ##
==========================================
- Coverage   89.80%   89.70%   -0.10%     
==========================================
  Files         672      670       -2     
  Lines      203907   203478     -429     
  Branches    39202    39060     -142     
==========================================
- Hits       183114   182540     -574     
- Misses      13115    13310     +195     
+ Partials     7678     7628      -50
Files with missing lines Coverage Δ
lib/internal/process/execution.js 94.17% <100.00%> (+0.04%) ⬆️

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70994/

aduh95 added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 24, 2026

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70998/

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71002/

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71006/

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71010/

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 24, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 25, 2026
nodejs-github-bot merged commit c1402c6 into nodejs:main Jan 25, 2026
66 of 68 checks passed

nodejs-github-bot commented Jan 25, 2026

Copy link
Copy Markdown
Collaborator

Landed in c1402c6

aduh95 pushed a commit that referenced this pull request Jan 28, 2026
process: do not truncate long strings in --print
b861451 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
mohd-akram deleted the fix-print branch February 2, 2026 14:28
mohd-akram mentioned this pull request Feb 6, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
process: do not truncate long strings in --print
924d9a5 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
process: do not truncate long strings in --print
16bab79 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit to juanarbol/node that referenced this pull request Jul 16, 2026
process: do not truncate long strings in --print
fbecadb 
Fixes: nodejs#61337
PR-URL: nodejs#61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Jul 17, 2026
process: do not truncate long strings in --print
edab2cd 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
juanarbol pushed a commit that referenced this pull request Jul 19, 2026
process: do not truncate long strings in --print
27fb167 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 29, 2026
process: do not truncate long strings in --print
b2e9fa9 
Fixes: #61337
PR-URL: #61497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node -p cuts off output when piped

4 participants

Back | FazBrowse Home | New Git URL