deps: upgrade npm to 3.8.6 by zkat · Pull Request #6153 · nodejs/node · GitHub

Checklist

tests and code linting passes
a test and/or benchmark is included
documentation is changed or added
the commit message follows commit guidelines

Affected core subsystem(s)

deps

Description of change

Hey y'all! I took care of this release while @iarna was out, so I'm doing the downstream for this one.

This PR includes the following releases:

Notable Changes

0d4a0b1 #11442 Fail if the user asks us to make a link from a module back on to itself. (@antialias)
b271ed2 #11983 Exit early if no arguments were provided to search instead of trying to display all the modules, running out of memory, and then crashing. (@SimenB)
f8fb4d8 #12079 Back in npm@3.2.2 we included a patch that made it so npm install pkg was basically npm install pkg@latest instead of pkg@* This is probably what most users expected, but it also ended up breaking npm deprecate when no version was provided for a package. In that case, we were using * to mean "deprecate all versions" and relying on the pkg -> pkg@* conversion. This patch fixes npm deprecate pkg to work as it used to by special casing that particular command's behavior. (@polm)
3e41360 #11987 Fix test that was inappropriately hitting the network (@yodeyer)
I added an extra hotfix to this PR, which is over at test: get rid of legacy test command from test-node npm/npm#12310 on the npm side, because our test-node script was still trying to invoke the legacy tests (which are now regular tests).
Various dependency and documentation updates.

You can see the full release notes at .

r: @iarna
r: @Fishrock123
r: @thealphanerd

@zkat hmm, looks like I'm getting this on master?

make test-npm
/Applications/Xcode.app/Contents/Developer/usr/bin/make -C out BUILDTYPE=Release V=1
make[1]: Nothing to be done for `all'.
ln -fs out/Release/node node
NODE=./node tools/test-npm.sh

...

> npm@3.8.6 test-node /Users/Jeremiah/Documents/node/test-npm
> "$NODE" ./test/run.js && "$NODE" "node_modules/.bin/tap" --timeout 240 "test/tap/*.js"

module.js:340
    throw err;
    ^

Error: Cannot find module '/Users/Jeremiah/Documents/node/test-npm/test/run.js'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:289:25)
    at Function.Module.runMain (module.js:450:10)
    at startup (node.js:156:18)
    at node.js:433:3

confirming I am getting the same error :sad:

Looks like npm/npm#11292 removed npm's test/run.js but didn't update the test-node script in npm's package.json that tools/test-npm.sh is calling.

Oh lol. I fixed that but it looks like I forgot to push the commit that fixes it. I'll push it up once I come in.

(You'll see I mentioned said patch in the notable changes list... second from last. And I still forgot. 🙃)

@Fishrock123 @thealphanerd fix'd :)

Still getting two errors:

test/tap/progress-config.js ......................... 15/17
  default-travis
  not ok should be disabled
    +++ found                                                          
    --- wanted                                                         
    -false                                                             
    +true                                                              
    compare: ===
    at:
      line: 47
      column: 7
      file: test/tap/progress-config.js
      type: EventEmitter
    stack: |
      EventEmitter.<anonymous> (test/tap/progress-config.js:47:7)
      _combinedTickCallback (internal/process/next_tick.js:67:7)
      process._tickCallback (internal/process/next_tick.js:98:9)
    source: |
      t.is(log.progressEnabled, false, 'should be disabled')

  default-ci
  not ok should be disabled
    +++ found                                                          
    --- wanted                                                         
    -false                                                             
    +true                                                              
    compare: ===
    at:
      line: 57
      column: 7
      file: test/tap/progress-config.js
      type: EventEmitter
    stack: |
      EventEmitter.<anonymous> (test/tap/progress-config.js:57:7)
      _combinedTickCallback (internal/process/next_tick.js:67:7)
      process._tickCallback (internal/process/next_tick.js:98:9)
    source: |
      t.is(log.progressEnabled, false, 'should be disabled')

That test fails if you have progress configured (to false or to true) in your .npmrc. We're gonna address that generally for our tests, but I don't think it should hold up merging, as its been present since the first stable npm@3 releases. (And also doesn't represent an error in the code its testing. It's an error in the test itself.)

Oh, I thought it would only fail if it was configured to false. Noted.

PR-URL: #6153 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>