build: add --shared-lief configure flag - #61536
Merged
aduh95 merged 1 commit intoJan 28, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
aduh95
commented
Jan 26, 2026
Comment thread
configure.py
Outdated
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #61536 +/- ##
==========================================
- Coverage 89.77% 88.91% -0.87%
==========================================
Files 673 673
Lines 203820 203820
Branches 39186 39102 -84
==========================================
- Hits 182982 181224 -1758
- Misses 13155 14878 +1723
- Partials 7683 7718 +35 see 108 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
legendecas
approved these changes
Jan 27, 2026
cjihrig
approved these changes
Jan 27, 2026
joyeecheung
approved these changes
Jan 27, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/61536 ✔ Done loading data for nodejs/node/pull/61536 ----------------------------------- PR info ------------------------------------ Title build: add `--shared-lief` configure flag (#61536) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:shared-lief -> nodejs:main Labels build, meta, tools, author ready, needs-ci, commit-queue-squash, dont-land-on-v20.x, dont-land-on-v22.x, dont-land-on-v24.x Commits 2 - build: add `--shared-lief` configure flag - Update configure.py Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 26 Jan 2026 20:19:05 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61536#pullrequestreview-3711758870 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61536#pullrequestreview-3711915227 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/61536#pullrequestreview-3713284258 ⚠ This PR has conflicts that must be resolved ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-01-27T15:05:38Z: https://ci.nodejs.org/job/node-test-pull-request/71070/ - Querying data for job/node-test-pull-request/71070/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21454260878 |
Sorry, something went wrong.
PR-URL: nodejs#61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
added a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
added a commit
that referenced
this pull request
Feb 2, 2026
PR-URL: #61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
added a commit
to himself65/node
that referenced
this pull request
Mar 11, 2026
PR-URL: nodejs#61536 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.