FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: aix: unflake test_threadsafe_function/test flaky on AIX by sxa · Pull Request #61560 · nodejs/node · GitHub

/ node Public

test: aix: unflake test_threadsafe_function/test flaky on AIX - #61560

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sxa:unflake_threadsafe
Jan 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test: aix: unflake test_threadsafe_function/test flaky on AIX#61560
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
sxa:unflake_threadsafe

Conversation

sxa commented Jan 28, 2026

Copy link
Copy Markdown
Member

This reverts commit 7698480.

Failure was only seen on one machine where an underlying problem has been resolved. This no longer needs to be marked as flaky.

nodejs-github-bot added needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 28, 2026

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71096/

codecov Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.78%. Comparing base (37e4004) to head (5f1be79).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #61560   +/-   ##
=======================================
  Coverage   89.78%   89.78%           
=======================================
  Files         673      673           
  Lines      203775   203775           
  Branches    39166    39167    +1     
=======================================
+ Hits       182956   182959    +3     
- Misses      13139    13152   +13     
+ Partials     7680     7664   -16

see 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71100/

sxa commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/71100/

Resuming due to smartos test failure:

12:46:56 Failed tests:
12:46:56 out/Release/node /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos22-x64/test/parallel/test-child-process-fork-closed-channel-segfault.js

sxa added v20.x v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jan 28, 2026
legendecas added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
nodejs-github-bot merged commit 7c537a3 into nodejs:main Jan 30, 2026
103 checks passed

nodejs-github-bot commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7c537a3

github-project-automation Bot moved this from Need Triage to Done in Node-API Team Project Jan 30, 2026
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
test: aix: unflake test_threadsafe_function/test flaky on AIX
c64bd7c 
This reverts commit 7698480.

PR-URL: #61560
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
test: aix: unflake test_threadsafe_function/test flaky on AIX
4726627 
This reverts commit 7698480.

PR-URL: #61560
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
legendecas legendecas approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

Node-API Team Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL