FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test_runner: fix passing `expectFailure` by MoLow · Pull Request #61568 · nodejs/node · GitHub

/ node Public

test_runner: fix passing expectFailure - #61568

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-passing-expect-failure
Jan 30, 2026
ConversationCommits (1)ChecksFiles changed
Merged

test_runner: fix passing expectFailure#61568
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
MoLow:fix-passing-expect-failure

Conversation

MoLow commented Jan 28, 2026

Copy link
Copy Markdown
Member

No description provided.

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner

nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Jan 28, 2026
JakobJingleheimer approved these changes Jan 28, 2026
View reviewed changes

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh wow, how did I miss this before 😵‍💫

🙌

MoLow commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

Oh wow, how did I miss this before 😵‍💫

All new experimental features evolve one way or another 🫶🏼

aduh95 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 28, 2026
MoLow force-pushed the fix-passing-expect-failure branch 2 times, most recently from d8d31da to 4c510a4 Compare January 28, 2026 17:57
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 28, 2026

nodejs-github-bot commented Jan 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71107/

MoLow force-pushed the fix-passing-expect-failure branch from 4c510a4 to 81d55bf Compare January 28, 2026 18:04

MoLow commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

@aduh95 thanks for the fast approvals. I changed the behavior a bit to better play when both skip and expectFailure are set

MoLow requested a review from aduh95 January 28, 2026 18:15

codecov Bot commented Jan 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (79ddd1b) to head (81d55bf).
⚠️ Report is 113 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61568      +/-   ##
==========================================
+ Coverage   88.53%   89.77%   +1.23%     
==========================================
  Files         704      673      -31     
  Lines      208876   203829    -5047     
  Branches    40330    39173    -1157     
==========================================
- Hits       184937   182980    -1957     
+ Misses      15922    13179    -2743     
+ Partials     8017     7670     -347
Files with missing lines Coverage Δ
lib/internal/test_runner/test.js 97.32% <100.00%> (+0.01%) ⬆️

... and 138 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2026

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71112/

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71114/

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71117/

MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026

atlowChemi commented Jan 29, 2026

Copy link
Copy Markdown
Member

@MoLow should there also be a new test with both skip & expectFailure, or do such tests exist?

ljharb commented Jan 29, 2026

Copy link
Copy Markdown
Member

a test that confirms that skip takes precedence over expectFailure would be valuable, but could be done in another PR too imo

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 30, 2026
nodejs-github-bot merged commit ea83d32 into nodejs:main Jan 30, 2026
66 of 67 checks passed

nodejs-github-bot commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Landed in ea83d32

MoLow deleted the fix-passing-expect-failure branch February 1, 2026 07:43
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
test_runner: fix passing expectFailure
ac3f6a6 
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
test_runner: fix passing expectFailure
fd8be14 
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
test_runner: fix passing expectFailure
a315792 
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
test_runner: fix passing expectFailure
2f6b136 
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
test_runner: fix passing expectFailure
6a4de69 
PR-URL: #61568
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
JakobJingleheimer JakobJingleheimer approved these changes
jakecastelli jakecastelli approved these changes
pmarchini pmarchini approved these changes
atlowChemi atlowChemi approved these changes
aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL