FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

assert: fix loose deepEqual arrays with undefined and null failing by BridgeAR · Pull Request #61587 · nodejs/node · GitHub

/ node Public

assert: fix loose deepEqual arrays with undefined and null failing - #61587

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
BridgeAR:BridgeAR/2026-01-30-fix-deep-equal
Feb 1, 2026
ConversationCommits (1)ChecksFiles changed
Merged

assert: fix loose deepEqual arrays with undefined and null failing#61587
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
BridgeAR:BridgeAR/2026-01-30-fix-deep-equal

Conversation

BridgeAR commented Jan 30, 2026

Copy link
Copy Markdown
Member

The comparison has to accept these as identical.

Fixes: #61583

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Jan 30, 2026
BridgeAR marked this pull request as draft January 30, 2026 12:41
BridgeAR force-pushed the BridgeAR/2026-01-30-fix-deep-equal branch from 3d8064f to 9d35d47 Compare January 30, 2026 12:43
assert: fix loose deepEqual arrays with undefined and null failing
225a1fd 
The comparison has to accept these as identical.

Fixes: nodejs#61583
BridgeAR force-pushed the BridgeAR/2026-01-30-fix-deep-equal branch from 9d35d47 to 225a1fd Compare January 30, 2026 12:50
BridgeAR marked this pull request as ready for review January 30, 2026 12:50

codecov Bot commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (784ca7b) to head (225a1fd).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61587      +/-   ##
==========================================
- Coverage   89.77%   89.76%   -0.01%     
==========================================
  Files         673      673              
  Lines      203840   203841       +1     
  Branches    39180    39182       +2     
==========================================
- Hits       182998   182983      -15     
- Misses      13156    13188      +32     
+ Partials     7686     7670      -16
Files with missing lines Coverage Δ
lib/internal/util/comparisons.js 99.71% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

atlowChemi added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 31, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 31, 2026

nodejs-github-bot commented Jan 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71144/

nodejs-github-bot commented Jan 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71147/

atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 1, 2026
nodejs-github-bot merged commit 27a7bbc into nodejs:main Feb 1, 2026
95 checks passed

nodejs-github-bot commented Feb 1, 2026

Copy link
Copy Markdown
Collaborator

Landed in 27a7bbc

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
assert: fix loose deepEqual arrays with undefined and null failing
926cd60 
The comparison has to accept these as identical.

Fixes: #61583
PR-URL: #61587
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
assert: fix loose deepEqual arrays with undefined and null failing
9c8d1b0 
The comparison has to accept these as identical.

Fixes: #61583
PR-URL: #61587
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
assert: fix loose deepEqual arrays with undefined and null failing
42fa62c 
The comparison has to accept these as identical.

Fixes: #61583
PR-URL: #61587
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
assert: fix loose deepEqual arrays with undefined and null failing
d4c6fcb 
The comparison has to accept these as identical.

Fixes: #61583
PR-URL: #61587
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
assert: fix loose deepEqual arrays with undefined and null failing
180778f 
The comparison has to accept these as identical.

Fixes: #61583
PR-URL: #61587
Reviewed-By: Jithil P Ponnan <jithil@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ljharb ljharb approved these changes
anonrig anonrig approved these changes
cjihrig cjihrig approved these changes
UlisesGascon UlisesGascon approved these changes
MrJithil MrJithil approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

assert.deepEqual([null], [undefined]) behavior changed in v22.16.0 (undocumented breaking change)

8 participants

Back | FazBrowse Home | New Git URL