| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks for the PR, a couple of comments, otherwise this looks good.
Sorry, something went wrong.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #61600 +/- ##
==========================================
- Coverage 89.76% 89.74% -0.03%
==========================================
Files 673 675 +2
Lines 203944 204538 +594
Branches 39191 39307 +116
==========================================
+ Hits 183080 183553 +473
- Misses 13194 13297 +103
- Partials 7670 7688 +18
... and 63 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
|
Thanks for the approval. I also verified make lint-js locally for the changed JS files. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
@inoway46 Can you squash the commits? I don't think they would pass the test individually. |
Sorry, something went wrong.
Remove the documented exception that extensionless files in type: "module" packages are recognized as CommonJS when included via require(). This exception conflicted with the ESM resolution specification which states that extensionless files within a package scope with an explicit type field follow the format of the type field. The behavior on main already matches the ESM spec since #61600, this change aligns the CJS documentation accordingly. Refs: #61600 Refs: #62083 PR-URL: #62176 Refs: #61600 Refs: #62083 Refs: #61971 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Remove the documented exception that extensionless files in type: "module" packages are recognized as CommonJS when included via require(). This exception conflicted with the ESM resolution specification which states that extensionless files within a package scope with an explicit type field follow the format of the type field. The behavior on main already matches the ESM spec since #61600, this change aligns the CJS documentation accordingly. Refs: #61600 Refs: #62083 PR-URL: #62176 Refs: #61600 Refs: #62083 Refs: #61971 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
To work around a crash on Node 25/26 (<nodejs/node#62083>) caused by an extensionless `./yargs` file in yargs@17 (<nodejs/node#62083>) which started being interpreted as `type: "module"` in Node.js 25.7 due to <nodejs/node#61600>, which was reverted by <nodejs/node#62083> for Node.js 25, but retained for Node.js 26. Work around the issue by overriding the c8 yargs dependency to use yargs@^18. Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
| Back | FazBrowse Home | New Git URL |
When an extensionless entry point contains ESM syntax but is in a package with "type": "commonjs" in package.json, the module would silently exit with code 0 without executing or showing any error. This happened because extensionless files skip the .js suffix check in the CJS loader, so the explicit type: commonjs was not being enforced, allowing ESM syntax to be silently delegated to ESM loading which never completed before the process exited.
This change ensures the CJS loader treats extensionless entry points as commonjs when type is explicitly set to "commonjs" in package.json, forcing ESM syntax to surface as a SyntaxError instead of silently exiting.
Fixes: #61104
Related: #61171 (alternative approach)