| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
Third Benchmark CI run, ternary: 01:03:52 confidence improvement accuracy (*) (**) (***) 01:03:52 buffers/buffer-hex-decode.js n=1000000 len=1024 *** 167.49 % ±1.45% ±1.94% ±2.56% 01:03:52 buffers/buffer-hex-decode.js n=1000000 len=64 *** 49.47 % ±1.94% ±2.59% ±3.38% 01:03:52 buffers/buffer-hex-encode.js n=1000000 len=1024 0.15 % ±0.17% ±0.22% ±0.29% 01:03:52 buffers/buffer-hex-encode.js n=1000000 len=64 0.06 % ±0.99% ±1.32% ±1.72% |
Sorry, something went wrong.
Failed to start CI⚠ No approving reviews found ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/22149104377 |
Sorry, something went wrong.
|
Note: this doesn't bump the version in header, like #61270 didn't bump it from 0.1.1 to 0.1.2 So it's still set there at 0.1.1 |
Sorry, something went wrong.
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Did you use tools/dep_updaters/update-nbytes.sh? Honestly I feel like we should only use the bot to update deps, fewer surprises and less work for everyone. |
Sorry, something went wrong.
|
@aduh95 No, I didn't #61270 is from the bot though and it didn't update the version from 0.1.1 to 0.1.2 |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Refs: nodejs/nbytes#12
Refs: nodejs/nbytes#13
Fixes the hex part of #60249 and improves Buffer#toString('hex') 2-4x
In local tests on a MacBook, this improves .toString('hex') throughput from ~2.24 GiB/s to ~9.53 GiB/s on ~80 KiB chunks
For comparison, Uint8Array#toHex() shows 3.28 GiB/s.
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1790/console