worker: fix TOCTOU race in CWD caching - #61725
Closed
mcollina wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The atomic counter used to signal CWD changes to worker threads was being incremented before chdir() completed, creating a race window where workers could cache stale directory paths with the new counter value. This caused process.cwd() in workers to return incorrect values until the next chdir() call. Fix by reordering operations: call originalChdir() first, then increment the counter. This ensures workers never cache stale data while believing it is current. Reported-by: Giulio Comi Reported-by: Caleb Everett
Copy link
Copy Markdown
Member
Author
|
cc @nodejs/tsc |
Sorry, something went wrong.
aduh95
approved these changes
Feb 7, 2026
Copy link
Copy Markdown
Member
|
FYI, a PR was opened by the community reporter at #61664. |
Sorry, something went wrong.
anonrig
approved these changes
Feb 7, 2026
anonrig
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nice catch.
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #61725 +/- ##
==========================================
+ Coverage 88.53% 89.75% +1.21%
==========================================
Files 703 675 -28
Lines 208538 204525 -4013
Branches 40224 39306 -918
==========================================
- Hits 184629 183565 -1064
+ Misses 15912 13241 -2671
+ Partials 7997 7719 -278
... and 199 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
approved these changes
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The atomic counter used to signal CWD changes to worker threads was
being incremented before chdir() completed, creating a race window
where workers could cache stale directory paths with the new counter
value. This caused process.cwd() in workers to return incorrect values
until the next chdir() call.
Fix by reordering operations: call originalChdir() first, then
increment the counter. This ensures workers never cache stale data
while believing it is current.
A unit test for this fix is not feasible as it would be too flaky due to the timing-dependent nature of the race condition.
Reported-by: Giulio Comi
Reported-by: Caleb Everett