FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gyp: Inherit CC/CXX for CC/CXX.host by jbergstroem · Pull Request #6173 · nodejs/node · GitHub

/ node Public

gyp: Inherit CC/CXX for CC/CXX.host - #6173

Merged
jbergstroem merged 1 commit into
nodejs:masterfrom
jbergstroem:fix/gyp-cxx.host
Apr 24, 2016
ConversationCommits (1)ChecksFiles changed
Merged

gyp: Inherit CC/CXX for CC/CXX.host#6173
jbergstroem merged 1 commit into
nodejs:masterfrom
jbergstroem:fix/gyp-cxx.host

Conversation

jbergstroem commented Apr 13, 2016

Copy link
Copy Markdown
Member
Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

tools/gyp

Description of change

Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++ through CC/CXX, lean against it (then drop to gcc/g++).

I don't think this will be accepted upstream but I guess I should give it a try.

Refs #6088 and fixes #6152.
/cc @srl295, @bnoordhuis.

jbergstroem commented Apr 13, 2016

Copy link
Copy Markdown
Member Author

CI without custom configure flags:
❎ https://ci.nodejs.org/job/node-test-commit/2900/ (unrelated fail on arm)

CI on FreeBSD with custom configure flags:
✅ https://ci.nodejs.org/job/node-test-commit-freebsd/2043/

bnoordhuis commented Apr 13, 2016

Copy link
Copy Markdown
Member

Can you try upstreaming it first? I don't want us to carry out-of-tree patches unless absolutely necessary.

jbergstroem commented Apr 13, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis: That was the plan -- just want to have a better look through their bug trackers first.

jbergstroem commented Apr 13, 2016

Copy link
Copy Markdown
Member Author

Upstream: https://bugs.chromium.org/p/gyp/issues/detail?id=515

bnoordhuis commented Apr 13, 2016

Copy link
Copy Markdown
Member

Can I suggest you upload the patch with git-cl upload? You'll get an answer quicker that way. CC gyp-developer@googlegroups.com if that isn't filled out automatically by https://codereview.chromium.org/.

jbergstroem commented Apr 13, 2016

Copy link
Copy Markdown
Member Author

Done: https://codereview.chromium.org/1887593002

mscdex added the build Issues and PRs related to build files or the CI. label Apr 13, 2016

bnoordhuis commented Apr 13, 2016

Copy link
Copy Markdown
Member

Maybe assign a reviewer as well. git shortlog -ns for that file suggests that thakis@ is a good choice. git-cl owners can be helpful, too.

joaocgreis commented Apr 13, 2016

Copy link
Copy Markdown
Member

LGTM here if it's rejected or gets stalled upstream

srl295 mentioned this pull request Apr 13, 2016
Closed

jbergstroem commented Apr 19, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis silent upstream -- I'd be keen on getting this in 6.x. There's still time but I'd just like a LGTM from you so I can land it quickly if needed.

bnoordhuis commented Apr 19, 2016

Copy link
Copy Markdown
Member

LGTM then.

jbergstroem commented Apr 19, 2016

Copy link
Copy Markdown
Member Author

Thanks. I will hold off for a week (or whatever's closing in on 6.x) until I merge as-is.

jasnell commented Apr 19, 2016

Copy link
Copy Markdown
Member

@jbergstroem ... the current plan is to cut the v6 release on Tuesday the 26th.

jbergstroem commented Apr 20, 2016

Copy link
Copy Markdown
Member Author

@bnoordhuis do we carry this in node-gyp too?

bnoordhuis mentioned this pull request Apr 20, 2016
Merged

bnoordhuis commented Apr 20, 2016

Copy link
Copy Markdown
Member

I guess we should for consistency: nodejs/node-gyp#908

jbergstroem commented Apr 24, 2016

Copy link
Copy Markdown
Member Author

Merging this. Was hoping for upstream but hopefully they'll catch up in time.

gyp: inherit parent for *.host
f1294f5 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

jbergstroem commented Apr 24, 2016

Copy link
Copy Markdown
Member Author

Final CI run: https://ci.nodejs.org/job/node-test-pull-request/2375/

jbergstroem commented Apr 24, 2016

Copy link
Copy Markdown
Member Author

PPC slaves unrelated.

jbergstroem merged commit f1294f5 into nodejs:master Apr 24, 2016
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
gyp: inherit parent for *.host
29d94c0 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
gyp: inherit parent for *.host
7cbd9fe 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins commented Jun 1, 2016

Copy link
Copy Markdown
Contributor

@jbergstroem is this something we would want for lts?

rvagg commented Jun 2, 2016

Copy link
Copy Markdown
Member

I think -1 for LTS, who knows what crazy build environments ppl have out there that this might impact

MylesBorins mentioned this pull request Jun 2, 2016
Closed

MylesBorins commented Jun 2, 2016

Copy link
Copy Markdown
Contributor

thanks @rvagg labeling as don't land

bnoordhuis pushed a commit to bnoordhuis/io.js that referenced this pull request Oct 8, 2016
gyp: inherit parent for *.host
c0141d8 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack pushed a commit that referenced this pull request Apr 18, 2017
gyp: inherit parent for *.host
d7a40a8 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack pushed a commit to refack/node-gyp that referenced this pull request Apr 23, 2017
gyp: inherit CC/CXX for CC/CXX.host
db2418d 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: nodejs#908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
evanlucas pushed a commit that referenced this pull request Apr 25, 2017
gyp: inherit parent for *.host
072591b 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas mentioned this pull request May 1, 2017
Merged
evanlucas pushed a commit that referenced this pull request May 1, 2017
gyp: inherit parent for *.host
d239613 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
evanlucas pushed a commit that referenced this pull request May 2, 2017
gyp: inherit parent for *.host
675244a 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack pushed a commit to refack/node that referenced this pull request Jul 18, 2017
gyp: inherit parent for *.host
4713f8e 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
refack pushed a commit to refack/node-gyp that referenced this pull request Aug 19, 2017
gyp: inherit CC/CXX for CC/CXX.host
742d4f9 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: nodejs#908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
refack pushed a commit to refack/node that referenced this pull request Aug 23, 2017
gyp: inherit parent for *.host
4cc7891 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs#6173
Fixes: nodejs#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
gyp: inherit parent for *.host
4a38b68 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs/node#6173
Fixes: nodejs/node#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
gyp: inherit parent for *.host
fcb75bd 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: nodejs/node#6173
Fixes: nodejs/node#6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
gyp: inherit parent for *.host
1fe09e1 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
gyp: inherit parent for *.host
7eb3679 
Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

Also apply the same logic for link/ar for consistency although
it doesn't affect us.

PR-URL: #6173
Fixes: #6152
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FreeBSD with small-icu fails: g++ not found

7 participants

Back | FazBrowse Home | New Git URL