FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v22.x] src: use std::sort in node_metadata for libc++13 compatibility by rebroad · Pull Request #61789 · nodejs/node · GitHub

/ node Public

[v22.x] src: use std::sort in node_metadata for libc++13 compatibility - #61789

Merged
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
rebroad:rebroad/armhf-libcxx13-fix-v22
Feb 23, 2026
ConversationCommits (1)ChecksFiles changed
Merged

[v22.x] src: use std::sort in node_metadata for libc++13 compatibility#61789
aduh95 merged 1 commit into
nodejs:v22.x-stagingfrom
rebroad:rebroad/armhf-libcxx13-fix-v22

Conversation

rebroad commented Feb 12, 2026

Copy link
Copy Markdown

Summary

This replaces std::ranges::sort() with std::sort(begin, end, ...) in src/node_metadata.cc.

Motivation

On armhf + clang-13/libc++13, std::ranges::sort is unavailable, causing Node v22 build failure.

Testing

  • Built on armhf (Raspberry Pi 3, 32-bit userspace)
  • Command: make -j2

Notes

  • No behavior change intended; sorting semantics are unchanged.

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Feb 12, 2026
rebroad changed the base branch from v22.x to v22.x-staging February 12, 2026 15:00
rebroad changed the title src: use std::sort in node_metadata for libc++13 compatibility [v22.x] src: use std::sort in node_metadata for libc++13 compatibility Feb 12, 2026
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026

addaleax commented Feb 12, 2026

Copy link
Copy Markdown
Member

Would be nice to add a note about why this doesn't affect 24.x and above in the commit message, though

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026

nodejs-github-bot commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71324/

rebroad force-pushed the rebroad/armhf-libcxx13-fix-v22 branch from dfff7a1 to f1670c5 Compare February 13, 2026 18:43

rebroad commented Feb 13, 2026

Copy link
Copy Markdown
Author

Would be nice to add a note about why this doesn't affect 24.x and above in the commit message, though

I've not looked at 24.x, so it might also affect that.

addaleax commented Feb 14, 2026

Copy link
Copy Markdown
Member

@rebroad Why does this PR target v22.x-staging then? That's generally reserved for PRs that either do not make sense on main anymore or backports of commits that otherwise don't cleanly apply on older release lines

Renegade334 commented Feb 14, 2026

Copy link
Copy Markdown
Member

The build requirements for v22.x are GCC 10.1 / Clang 13 targeting C++17; std::ranges is a C++20 feature that existed in GCC 10 but not until Clang 14, which I guess is the hiccup.

addaleax added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 17, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

nodejs-github-bot commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71358/

aduh95 force-pushed the v22.x-staging branch 2 times, most recently from b7ac8a3 to 4ef4225 Compare February 21, 2026 22:45

nodejs-github-bot commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71413/

nodejs-github-bot commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71419/

aduh95 merged commit bd1da67 into nodejs:v22.x-staging Feb 23, 2026
62 of 64 checks passed

aduh95 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

Landed in bd1da67

aduh95 pushed a commit that referenced this pull request Feb 23, 2026
src: replace ranges::sort for libc++13 compatibility on armhf
d27668e 
PR-URL: #61789
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Feb 24, 2026
src: replace ranges::sort for libc++13 compatibility on armhf
35a12fb 
PR-URL: #61789
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 mentioned this pull request Feb 24, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL