FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

[v24.x backport] build: add support for Visual Studio 2026 by MikeMcC399 · Pull Request #61840 · nodejs/node · GitHub

/ node Public

[v24.x backport] build: add support for Visual Studio 2026 - #61840

Closed
MikeMcC399 wants to merge 2 commits into
nodejs:v24.x-stagingfrom
MikeMcC399:backport-60727-to-v24.x
ConversationCommits (2)ChecksFiles changed
Closed

[v24.x backport] build: add support for Visual Studio 2026#61840
MikeMcC399 wants to merge 2 commits into
nodejs:v24.x-stagingfrom
MikeMcC399:backport-60727-to-v24.x

Conversation

MikeMcC399 commented Feb 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backporting 2 interrelated PRs:

commit a4b05c133bed7263ba2ef3b983ebe0a6c4101d12
Author: Michaël Zasso targos@protonmail.com
Date: Wed Nov 19 17:01:37 2025 +0100

build: add support for Visual Studio 2026

Backport-PR-URL: https://github.com/nodejs/node/pull/61840
PR-URL: https://github.com/nodejs/node/pull/60727
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>

commit 25c5353c475dd29a3e2fd31747b657559f25b182
Author: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Date: Wed Jan 28 15:52:43 2026 +0100

build,win: fix vs2022 compilation

Backport-PR-URL: https://github.com/nodejs/node/pull/61840
PR-URL: https://github.com/nodejs/node/pull/61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

Situation

BUILDING > Supported toolchains for the v24.x branch shows:

Operating System Compiler Versions
Windows Visual Studio >= 2022 with the Windows 10 SDK on a 64-bit host

With only Visual Studio 2026 Build Tools Edition from https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2026 installed with necessary prerequisites (no side-by-side Visual Studio 2022 installed), executing .\vcbuild in a PowerShell 7 terminal fails, although the "Supported toolchains" suggest that Visual Studio 2026 should be supported.

Looking for Visual Studio 2022
Failed to find a suitable Visual Studio installation with Clang compiler/LLVM toolset.

Change

Cherry-pick 934d907 from #60727

Preserve the [nocorepack] option in vcbuild.bat v24.x, which was removed for >=v25.x, to resolve a cherry-pick conflict.

Also cherry-pick 5a8864d from #61530 to fix a one line bug in #60727 which prevented selecting Visual Studio 2022 with .\vcbuild vs2022 in a side-by-side configuration where both Visual Studio 2022 and 2026 were installed.

Verification

In Windows 11 25H2 with Visual Studio 2022 & 2026 variously installed / not installed, ensure that all valid command combinations of .\vcbuild run:

Command Visual Studio 2022 installed Visual Studio 2026 installed Studio version selected
.\vcbuild YES NO vs2022
.\vcbuild vs2022 YES NO vs2022
.\vcbuild YES YES vs2026
.\vcbuild vs2022 YES YES vs2022
.\vcbuild vs2026 YES YES vs2026
.\vcbuild NO YES vs2026
.\vcbuild v2026 NO YES vs2026

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. windows Issues and PRs related to the Windows platform. labels Feb 15, 2026
MikeMcC399 marked this pull request as ready for review February 15, 2026 18:06
This was referenced Feb 15, 2026
Merged
Closed
Closed
Merged

Renegade334 commented Feb 17, 2026

Copy link
Copy Markdown
Member

For releasers, can you prepend Backport-PR-URL: https://github.com/nodejs/node/pull/61840 to your commit trailers?

MikeMcC399 force-pushed the backport-60727-to-v24.x branch from 1f34ed6 to 25c5353 Compare February 18, 2026 09:35

MikeMcC399 commented Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

@Renegade334

For releasers, can you prepend Backport-PR-URL: #61840 to your commit trailers?

Thanks for your guidance! I did read in https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#manual-process that it says:

The Backport-PR-URL metadata does need to be added to the commit, but this will be done later.

So the instructions aren't really very specific about whose action this is and what is supposed to be done.

I have added the Backport-PR-URL metadata now and force pushed. Hopefully I got this right!

Renegade334 commented Feb 18, 2026

Copy link
Copy Markdown
Member

Thanks. I believe that advice only applies to git node backport which adds the backport metadata during the landing session.

Renegade334 added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 18, 2026
github-actions Bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 18, 2026

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view
Renegade334 added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 18, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026

nodejs-github-bot commented Feb 18, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71368/

aduh95 requested a review from a team as a code owner February 22, 2026 22:44
MikeMcC399 force-pushed the backport-60727-to-v24.x branch from 25c5353 to 53e950e Compare February 23, 2026 09:59

This comment was marked as outdated.

Sign in to view
MikeMcC399 marked this pull request as draft February 23, 2026 10:03
MikeMcC399 force-pushed the backport-60727-to-v24.x branch from 53e950e to b184511 Compare February 23, 2026 10:07
MikeMcC399 marked this pull request as ready for review February 23, 2026 10:08

This comment was marked as resolved.

Sign in to view

aduh95 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor

For releasers, can you prepend Backport-PR-URL: https://github.com/nodejs/node/pull/61840 to your commit trailers?

That's actually discouraged, it's preferable to keep the commit message as is, the tooling will add the correct metadata

targos and others added 2 commits February 23, 2026 14:40
build: add support for Visual Studio 2026
9d51a08 
PR-URL: nodejs#60727
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
build,win: fix vs2022 compilation
800ab9b 
PR-URL: nodejs#61530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
MikeMcC399 force-pushed the backport-60727-to-v24.x branch from b184511 to 800ab9b Compare February 23, 2026 13:41

MikeMcC399 commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

@aduh95

For releasers, can you prepend Backport-PR-URL: https://github.com/nodejs/node/pull/61840 to your commit trailers?

That's actually discouraged, it's preferable to keep the commit message as is, the tooling will add the correct metadata

I've removed the unwanted Backport-PR-URL metadata and force-pushed.

MikeMcC399 mentioned this pull request Feb 23, 2026
Closed

nodejs-github-bot commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71415/

nodejs-github-bot commented Feb 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71422/

aduh95 pushed a commit that referenced this pull request Feb 23, 2026
build: add support for Visual Studio 2026
4c10584 
PR-URL: #60727
Backport-PR-URL: #61840
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
aduh95 pushed a commit that referenced this pull request Feb 23, 2026
build,win: fix vs2022 compilation
6a4511b 
PR-URL: #61530
Backport-PR-URL: #61840
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>

aduh95 commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

Landed in f98986c...6a4511b

aduh95 closed this Feb 24, 2026
MikeMcC399 deleted the backport-60727-to-v24.x branch February 24, 2026 10:27
MikeMcC399 mentioned this pull request Apr 10, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Renegade334 Renegade334 approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL