FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

url, querystring: optimize serialization and encoding performance by TylerFortune · Pull Request #61896 · nodejs/node · GitHub

/ node Public

url, querystring: optimize serialization and encoding performance - #61896

Open
TylerFortune wants to merge 2 commits into
nodejs:mainfrom
TylerFortune:perf-url-querystring
ConversationCommits (2)ChecksFiles changed
Open

url, querystring: optimize serialization and encoding performance#61896
TylerFortune wants to merge 2 commits into
nodejs:mainfrom
TylerFortune:perf-url-querystring

Conversation

TylerFortune commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

This PR optimizes the performance of URLSearchParams.prototype.toString() and the internal encodeStr utility used by querystring.

  1. URLSearchParams: Refactored serializeParams in lib/internal/url.js to use a pre-allocated array instead of iterative string concatenation. This shifts complexity from $O(N^2)$ to $O(N)$.
  2. Querystring: Introduced a high-performance fast-path in lib/internal/querystring.js for strings under 10 characters using direct string concatenation.

Technical Details

  • Complexity Shift: Resolves the quadratic growth issue identified in fs: fix fd leak in ReadStream.destroy() #56.
  • Fast-Path: Threshold of 10 characters identified as the optimal cross-over point via micro-benchmarks.
  • WPT Status: 100% compliant with WHATWG URL standards.

Performance Results (AMD Ryzen 7)

Detailed data is included in the committed PERFORMANCE_REPORT.md.

  • 1000 Params (ASCII): +34.5% throughput
  • Internal encodeStr (<10 chars): ~4.7x speedup

Fixes: nodejs/performance#56
Refs: #61896

perf: optimize URLSearchParams and encodeStr
cea7fe3 
- Implement O(N) pre-allocation for URLSearchParams.prototype.toString()
- Add string concatenation fast-path for short strings in encodeStr
- Align internal serialization with fast-querystring patterns

Fixes: nodejs/performance#56

nodejs-github-bot commented Feb 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/url

nodejs-github-bot added doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. querystring Issues and PRs related to the built-in querystring module. whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Feb 20, 2026
mcollina reviewed Feb 20, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Did you run the microbenchmarks you added?

Comment thread PERFORMANCE_REPORT.md
@@ -0,0 +1,93 @@
# Performance Report: URLSearchParams and Querystring Optimization

## 1. Executive Summary

mcollina Feb 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Remove this file.

codecov Bot commented Feb 20, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.77%. Comparing base (94b1f66) to head (78dc5c4).
⚠️ Report is 1463 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #61896      +/-   ##
==========================================
- Coverage   91.77%   89.77%   -2.00%     
==========================================
  Files         338      674     +336     
  Lines      140064   204923   +64859     
  Branches    22045    39392   +17347     
==========================================
+ Hits       128543   183972   +55429     
- Misses      11298    13229    +1931     
- Partials      223     7722    +7499
Files with missing lines Coverage Δ
lib/internal/querystring.js 100.00% <100.00%> (ø)
lib/internal/url.js 93.65% <100.00%> (+14.07%) ⬆️

... and 459 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

github-actions Bot added the stale label Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. needs-ci PRs that need a full CI run. querystring Issues and PRs related to the built-in querystring module. stale whatwg-url Issues and PRs related to the WHATWG URL implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve the performance of both URLSearchParams.toString and querystring.stringify

3 participants

Back | FazBrowse Home | New Git URL