FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

sqlite: bind Boolean by mike-git374 · Pull Request #62001 · nodejs/node · GitHub

/ node Public

sqlite: bind Boolean - #62001

Closed
mike-git374 wants to merge 7 commits into
nodejs:mainfrom
mike-git374:sqlite-bind-boolean
ConversationCommits (7)ChecksFiles changed
Closed

sqlite: bind Boolean#62001
mike-git374 wants to merge 7 commits into
nodejs:mainfrom
mike-git374:sqlite-bind-boolean

Conversation

mike-git374 commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Fixes: #57862

nodejs-github-bot commented Feb 26, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Feb 26, 2026
louwers reviewed Feb 26, 2026
View reviewed changes
Comment thread src/node_sqlite.cc
Update comment
7e8f43d
comment update
881fb94 
Reword comments for clarity regarding JS types and SQLite.
test consolidate
ac38ba9
mike-git374 mentioned this pull request Feb 27, 2026
Open
thisalihassan reviewed Mar 6, 2026
View reviewed changes

thisalihassan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

trivikr added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Jul 25, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 26, 2026

This comment was marked as outdated.

Sign in to view
mike-git374 mentioned this pull request Aug 4, 2026
Closed
TrevorBurnham mentioned this pull request Aug 4, 2026
Open

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75552/

trivikr pushed a commit that referenced this pull request Aug 6, 2026
sqlite: bind Boolean
de333e8 
PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>

trivikr commented Aug 6, 2026

Copy link
Copy Markdown
Member

Landed in de333e8

trivikr closed this Aug 6, 2026
araujogui mentioned this pull request Aug 6, 2026
Merged
nodejs-github-bot pushed a commit that referenced this pull request Aug 8, 2026
doc: document sqlite parameter binding
114e356 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
sqlite: bind Boolean
4aa40e7 
PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
doc: document sqlite parameter binding
67829bb 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
sqlite: bind Boolean
49fb028 
PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
doc: document sqlite parameter binding
e52e573 
Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
github-actions Bot mentioned this pull request Aug 25, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

himself65 himself65 approved these changes
+2 more reviewers
louwers louwers left review comments
thisalihassan thisalihassan left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQLite bind booleans

6 participants

Back | FazBrowse Home | New Git URL