doc: clarify sqlite bare named parameter default - #62009
Merged
nodejs-github-bot merged 1 commit intoAug 8, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mike-git374
reviewed
Feb 26, 2026
mike-git374
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I approve the PR and the wording is correct, but I suggest this 1 change. Then might need to re-lint
Sorry, something went wrong.
Comment thread
doc/api/sqlite.md
Outdated
| parameters. However, with the exception of dollar sign character, these | ||
| prefix characters also require extra quoting when used in object keys. | ||
| `node:sqlite` allows binding named parameters without this prefix character in | ||
| JavaScript code. With the exception of the dollar sign character, these prefix |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| JavaScript code. With the exception of the dollar sign character, these prefix | |
| the parameter object. With the exception of the dollar sign character, these prefix |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@skdas20 Can you please sign the first commit and force push? It's required as per instructions
|
Sorry, something went wrong.
Signed-off-by: skdas20 <skdas5405@gmail.com>
skdas20
force-pushed
the
docs/sqlite-allow-bare-named-params-61823
branch
from
a6301f7 to
b571db8
Compare
July 27, 2026 05:00
Copy link
Copy Markdown
Member
|
cc @nodejs/sqlite |
Sorry, something went wrong.
trivikr
approved these changes
Aug 8, 2026
aduh95
pushed a commit
that referenced
this pull request
Aug 13, 2026
Signed-off-by: skdas20 <skdas5405@gmail.com> PR-URL: #62009 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
Signed-off-by: skdas20 <skdas5405@gmail.com> PR-URL: #62009 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61823
Summary
Updates statement.setAllowBareNamedParameters() documentation to match the actual default behavior.
Validation
Ran markdown lint on the changed file:
Result: exit code 0.