FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: skip dockit on riscv64 by sxa · Pull Request #62251 · nodejs/node · GitHub

/ node Public

build: skip dockit on riscv64 - #62251

Draft
sxa wants to merge 1 commit into
nodejs:mainfrom
sxa:nodoc_riscv64
ConversationCommits (1)ChecksFiles changed
Draft

build: skip dockit on riscv64#62251
sxa wants to merge 1 commit into
nodejs:mainfrom
sxa:nodoc_riscv64

Conversation

sxa commented Mar 14, 2026

Copy link
Copy Markdown
Member

The doc-only target gives a variety of failures on different riscv64 systems. These symptoms are described in nodejs/build#4099 (comment) in the section Additional info on the Wasm doc-only crash

This removes the doc-only target from being run by default as part of make test-ci similar to what has been done for AIX and IBMi.

build: skip dockit on riscv64
ffdb03c 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 14, 2026
sxa marked this pull request as draft March 14, 2026 10:58

codecov Bot commented Mar 14, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (8ccbe8e) to head (ffdb03c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62251      +/-   ##
==========================================
- Coverage   89.68%   89.67%   -0.02%     
==========================================
  Files         676      676              
  Lines      206495   206495              
  Branches    39537    39542       +5     
==========================================
- Hits       185204   185175      -29     
- Misses      13435    13444       +9     
- Partials     7856     7876      +20

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kxxt commented Mar 21, 2026

Copy link
Copy Markdown
Member

I think we can fix it (at least the WebAssembly.instantiate(): Out of memory: Cannot allocate Wasm memory for new instance part) by bumping @nodejs/doc-kit after nodejs/doc-kit#691 is merged.

kxxt commented Apr 11, 2026

Copy link
Copy Markdown
Member

by bumping @nodejs/doc-kit after nodejs/doc-kit#691 is merged.

#62686

sxa commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Probably fixed with the updae in #62512 - running a test on my K1 at https://ci.nodejs.org/job/sxa-rvnodetest/399/

sxa self-assigned this Aug 26, 2026

sxa commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Noting that I hit this again today with a branch that had the doc-kit 1.4.1 added in https://github.com/nodejs/node/pull/64010/changes so this may still be required.

0:52:24 cp -r doc/api out/doc
20:52:25 npm warn cli npm v11.17.0 does not support Node.js v26.5.1-pre. This version of npm supports the following node versions: `^20.17.0 || >=22.9.0`. You can find the latest version at https://nodejs.org/.
20:52:36 
20:52:36 added 280 packages, and audited 282 packages in 11s
20:52:36 
20:52:36 137 packages are looking for funding
20:52:36   run `npm fund` for details
20:52:36 
20:52:36 1 moderate severity vulnerability
20:52:36 
20:52:36 To address all issues, run:
20:52:36   npm audit fix
20:52:36 
20:52:36 Run `npm audit` for details.
20:53:25 [19:53:25.175] ERROR: WebAssembly.Instance(): Out of memory: Cannot allocate Wasm memory for new instance
20:53:25 RangeError: WebAssembly.Instance(): Out of memory: Cannot allocate Wasm memory for new instance

Ref: https://ci.nodejs.org/job/sxa-node-test-commit-rvlinux/14/nodes=riscv64

sxa mentioned this pull request Aug 26, 2026
Open
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

sxa

Labels

build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL