FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix stray carriage return in packages.md by panva · Pull Request #62350 · nodejs/node · GitHub

/ node Public

doc: fix stray carriage return in packages.md - #62350

Merged
Renegade334 merged 1 commit into
nodejs:mainfrom
panva:stray-carriage-return
Mar 20, 2026
ConversationCommits (1)ChecksFiles changed
Merged

doc: fix stray carriage return in packages.md#62350
Renegade334 merged 1 commit into
nodejs:mainfrom
panva:stray-carriage-return

Conversation

panva commented Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

panva added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 20, 2026

nodejs-github-bot commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders

github-actions Bot commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 20, 2026
aduh95 approved these changes Mar 20, 2026
View reviewed changes

aduh95 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Very hard to spot, a shame GitHub UI nor the linter is able to help us catch that

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 20, 2026
Renegade334 approved these changes Mar 20, 2026
View reviewed changes

Renegade334 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💪🪟

JakobJingleheimer approved these changes Mar 20, 2026
View reviewed changes

JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🙏

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 20, 2026

nodejs-github-bot commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/62350
✔  Done loading data for nodejs/node/pull/62350
----------------------------------- PR info ------------------------------------
Title      doc: fix stray carriage return in packages.md (#62350)
Author     Filip Skokan <panva.ip@gmail.com> (@panva)
Branch     panva:stray-carriage-return -> nodejs:main
Labels     doc, fast-track
Commits    1
 - doc: fix stray carriage return in packages.md
Committers 1
 - Filip Skokan <panva.ip@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62350
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: https://github.com/nodejs/node/pull/62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62350
Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609
Refs: https://github.com/nodejs/node/pull/62302
Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Jacob Smith <jacob@frende.me>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 20 Mar 2026 14:26:56 GMT
   ✔  Approvals: 5
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3981907555
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982025863
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982152226
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982194999
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/62350#pullrequestreview-3982214292
   ℹ  This PR is being fast-tracked
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 62350
From https://github.com/nodejs/node
 * branch                  refs/pull/62350/merge -> FETCH_HEAD
✔  Fetched commits as 052aec7127f4..385a91a55f03
--------------------------------------------------------------------------------
[main ba5c2fd55c] doc: fix stray carriage return in packages.md
 Author: Filip Skokan <panva.ip@gmail.com>
 Date: Fri Mar 20 15:14:17 2026 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
doc: fix stray carriage return in packages.md

PR-URL: #62350

Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1774015976262609

Refs: #62302

Refs: https://github.com/nodejs/node/actions/runs/23347139396/job/67915524762?pr=61767

Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>

Reviewed-By: Chemi Atlow <chemi@atlow.co.il>

Reviewed-By: Jacob Smith <jacob@frende.me>


[main f70e40c0a8] doc: fix stray carriage return in packages.md

Author: Filip Skokan <panva.ip@gmail.com>

Date: Fri Mar 20 15:14:17 2026 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

✔  f70e40c0a80b6aebef212d34640d9fcad4d1f21d

✔  0:0      no Co-authored-by metadata                co-authored-by-is-trailer

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length


The following commits are ready to be pushed to origin/main


    

  • f70e40c0a8 doc: fix stray carriage return in packages.md
    • 





Temporary files removed.

To finish landing:


    

  1. Run:
    
git push origin main
    2. 

  2. Post "Landed in f70e40c0a80b" in doc: fix stray carriage return in packages.md #62350
    
gh pr comment doc: fix stray carriage return in packages.md #62350 --body "Landed in f70e40c0a80b"
    
gh pr close doc: fix stray carriage return in packages.md #62350
https://github.com/nodejs/node/actions/runs/23351358101

Renegade334 merged commit b2c5235 into nodejs:main Mar 20, 2026
33 of 34 checks passed

Renegade334 commented Mar 20, 2026

Copy link
Copy Markdown
Member

Landed (kicking and screaming) in b2c5235

Renegade334 removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Mar 20, 2026
panva deleted the stray-carriage-return branch March 21, 2026 16:27
aduh95 added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Mar 25, 2026

aduh95 commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

To make everyone's life easier, I've fixed the original commit when cherry-picking it on v25.x-staging (f67febf) and marked this one as dont-land.

RafaelGSS mentioned this pull request Apr 27, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

JakobJingleheimer JakobJingleheimer approved these changes
legendecas legendecas approved these changes
Renegade334 Renegade334 approved these changes
aduh95 aduh95 approved these changes
atlowChemi atlowChemi approved these changes

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL