| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Can you open a different pull-request for this? |
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #62352 +/- ##
=======================================
Coverage 90.15% 90.16%
=======================================
Files 751 751
Lines 253443 253443
Branches 47729 47731 +2
=======================================
+ Hits 228496 228508 +12
- Misses 16201 16208 +7
+ Partials 8746 8727 -19 see 37 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Sure, open #62356. |
Sorry, something went wrong.
|
Can you update this PR? |
Sorry, something went wrong.
Sorry, something went wrong.
|
It seems that CI errors are not related, could anyone restart the CI? |
Sorry, something went wrong.
|
This pull request has been marked as stale due to 90 days of inactivity. |
Sorry, something went wrong.
|
Not stale. I don't have the Jenkins CI permission so don't what is going on, could anyone restart the CI? |
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! The pull request was removed from the Commit Queue and labeled commit-queue-failed An error occurred while landing this pull request using GitHub Actions. . After resolving the failure, remove that label and add commit-queue Add this label to land a pull request using GitHub Actions. to retry. Full Commit Queue output- Loading data for nodejs/node/pull/62352
✔ Done loading data for nodejs/node/pull/62352
----------------------------------- PR info ------------------------------------
Title tools: enable eslint concurrency mode (#62352)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch JLHwung:improve-eslint-ci-perf -> nodejs:main
Labels build, tools, author ready, needs-ci, commit-queue
Commits 1
- tools: enable concurrency for eslint
Committers 1
- Huáng Jùnliàng <jlhwung@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
ℹ This PR was created on Fri, 20 Mar 2026 15:30:45 GMT
✔ Approvals: 4
✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/62352#pullrequestreview-3988128487
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/62352#pullrequestreview-3988257998
✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/62352#pullrequestreview-4009815856
✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/62352#pullrequestreview-4010284063
✔ Last GitHub CI successful
ℹ Last Full PR CI on 2026-08-23T15:35:56Z: https://ci.nodejs.org/job/node-test-pull-request/76300/
- Querying data for job/node-test-pull-request/76300/
✔ Build data downloaded
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ No git cherry-pick in progress
✔ No git am in progress
✔ No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
* branch main -> FETCH_HEAD
✔ origin/main is now up-to-date
- Downloading patch for 62352
From https://github.com/nodejs/node
* branch refs/pull/62352/merge -> FETCH_HEAD
✔ Fetched commits as 82e7ff4f8452..7831d51999ce
--------------------------------------------------------------------------------
Auto-merging Makefile
[main 00fec459bd] tools: enable concurrency for eslint
Author: Huáng Jùnliàng <jlhwung@gmail.com>
Date: Wed Mar 18 17:59:15 2026 -0400
1 file changed, 3 insertions(+), 2 deletions(-)
✔ Patches applied
--------------------------------------------------------------------------------
--------------------------------- New Message ----------------------------------
tools: enable concurrency for eslint
PR-URL: https://github.com/nodejs/node/pull/62352
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
--------------------------------------------------------------------------------
[main f2176a2fec] tools: enable concurrency for eslint
Author: Huáng Jùnliàng <jlhwung@gmail.com>
Date: Wed Mar 18 17:59:15 2026 -0400
1 file changed, 3 insertions(+), 2 deletions(-)
✖ f2176a2fecb36e79913dd64262061e9eb7a185ef
✔ 0:0 no Assisted-by metadata assisted-by-is-trailer
✔ 0:0 no Co-authored-by metadata co-authored-by-is-trailer
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✖ 0:0 Commit must have a "Signed-off-by" trailer signed-off-by
✔ 0:0 valid subsystems subsystem
✔ 0:0 Title is formatted correctly. title-format
✔ 0:0 Title is <= 50 columns. title-length
--------------------------------------------------------------------------------
ℹ Please fix the commit message and try again.
Please manually ammend the commit message, by running
`git commit --amend`
Once commit message is fixed, finish the landing command running
`git node land --continue`
|
Sorry, something went wrong.
|
@JLHwung Can you please sign your commit message and force push? It's required as per instructions
|
Sorry, something went wrong.
Signed-off-by: Huáng Jùnliàng <jlhwung@gmail.com>
Thank you. Rebased and signed off. |
Sorry, something went wrong.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
In this PR we enable the ESLint --concurrency mode. Per report from TIME(1), a cache-missed eslint job has improved from 75 seconds to 25 seconds on my machine. In the cache-hit scenario, both mode exit in less than 2 seconds.