FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: align Readable.toWeb termination with eos by ikeyan · Pull Request #62394 · nodejs/node · GitHub

/ node Public

stream: align Readable.toWeb termination with eos - #62394

Merged
aduh95 merged 12 commits into
nodejs:mainfrom
ikeyan:fix-stream-readable-to-web
May 19, 2026
ConversationCommits (12)ChecksFiles changed
Merged

stream: align Readable.toWeb termination with eos#62394
aduh95 merged 12 commits into
nodejs:mainfrom
ikeyan:fix-stream-readable-to-web

Conversation

ikeyan commented Mar 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This aligns Readable.toWeb(stream) termination handling with
eos(stream, { writable: false }).

Changes:

  • add regression tests for half-open duplex termination
  • add regression coverage for adapter creation before and after
    end(), destroy(), and destroy(error)
  • preserve terminated Readable adapter state, including closed/error
    state and byte stream type, regardless of when the adapter is created
  • let Readable.toWeb() reuse eos() immediate completion handling
    for already-terminated streams
  • add regression coverage for the synchronous internal EOS callback
    path, including listener cleanup and BYOB termination

Tests:

  • make lint
  • ./configure && make -j4 test

nodejs-github-bot commented Mar 22, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/streams

nodejs-github-bot added needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. web streams labels Mar 22, 2026

codecov Bot commented Mar 22, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.69%. Comparing base (8199f9c) to head (4922bc4).
⚠️ Report is 529 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62394      +/-   ##
==========================================
- Coverage   89.69%   89.69%   -0.01%     
==========================================
  Files         676      676              
  Lines      206693   206767      +74     
  Branches    39577    39588      +11     
==========================================
+ Hits       185402   185457      +55     
- Misses      13435    13442       +7     
- Partials     7856     7868      +12
Files with missing lines Coverage Δ
lib/internal/streams/end-of-stream.js 98.52% <100.00%> (+1.10%) ⬆️
lib/internal/webstreams/adapters.js 86.43% <100.00%> (-0.02%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MattiasBuelens added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 23, 2026
ikeyan force-pushed the fix-stream-readable-to-web branch from b9b8a96 to a0fd4b7 Compare March 24, 2026 02:11

ikeyan commented Mar 24, 2026

Copy link
Copy Markdown
Contributor Author

Nothing to do now. Ready to merge.

MattiasBuelens added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 25, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026

nodejs-github-bot commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71925/

nodejs-github-bot commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72185/

nodejs-github-bot commented Apr 10, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72614/

nodejs-github-bot commented Apr 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72631/

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 19, 2026
aduh95 merged commit 783b382 into nodejs:main May 19, 2026
74 checks passed

aduh95 commented May 19, 2026

Copy link
Copy Markdown
Contributor

Landed in 783b382

trivikr mentioned this pull request May 21, 2026
Closed
aduh95 pushed a commit that referenced this pull request May 22, 2026
stream: align Readable.toWeb termination with eos
cbee0de 
PR-URL: #62394
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
github-actions Bot mentioned this pull request May 30, 2026
Merged
ikeyan deleted the fix-stream-readable-to-web branch June 29, 2026 06:15
aduh95 mentioned this pull request Jul 22, 2026
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
stream: align Readable.toWeb termination with eos
d597e29 
PR-URL: nodejs#62394
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
stream: align Readable.toWeb termination with eos
5658c63 
PR-URL: #62394
Backport-PR-URL: #64675
Reviewed-By: Mattias Buelens <mattias@buelens.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Menci mentioned this pull request Aug 6, 2026
Merged
9 tasks
github-actions Bot mentioned this pull request Aug 21, 2026
Open
richardscarrott mentioned this pull request Aug 23, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
MattiasBuelens MattiasBuelens approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. stream Issues and PRs related to the stream subsystem. web streams

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL