FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: use `CARGO` environment variable if set by richardlau · Pull Request #62421 · nodejs/node · GitHub

/ node Public

build: use CARGO environment variable if set - #62421

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:cargo
Apr 1, 2026
ConversationCommits (1)ChecksFiles changed
Merged

build: use CARGO environment variable if set#62421
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
richardlau:cargo

Conversation

richardlau commented Mar 24, 2026

Copy link
Copy Markdown
Member

When enabling support for Temporal, check for the CARGO environment variable to locate the cargo binary (defaulting to cargo if not set) and use this to build deps/crates.

This will allow using Cargo on systems where the Cargo binary name is suffixed with the version, e.g. cargo-1.82 on Ubuntu 24.04.

nodejs-github-bot commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg

nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Mar 24, 2026
richardlau mentioned this pull request Mar 24, 2026
Closed
75 tasks
addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 24, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 25, 2026

nodejs-github-bot commented Mar 25, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71922/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71948/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72001/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72002/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72004/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72006/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72008/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72010/

nodejs-github-bot commented Mar 26, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72041/

nodejs-github-bot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72074/

nodejs-github-bot commented Mar 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72080/

nodejs-github-bot commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72341/

nodejs-github-bot commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72342/

build: use CARGO environment variable if set
15e7631 
When enabling support for Temporal, check for the `CARGO` environment
variable to locate the `cargo` binary (defaulting to `cargo` if not
set) and use this to build `deps/crates`.

This will allow using Cargo on systems where the Cargo binary name is
suffixed with the version, e.g. `cargo-1.82` on Ubuntu 24.04.

nodejs-github-bot commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72349/

richardlau commented Mar 31, 2026

Copy link
Copy Markdown
Member Author

(rebased to see if that makes the Windows flakes go away)

nodejs-github-bot commented Mar 31, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72359/

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 1, 2026
nodejs-github-bot merged commit 7b8934d into nodejs:main Apr 1, 2026
60 checks passed

nodejs-github-bot commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7b8934d

richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Apr 1, 2026
richardlau deleted the cargo branch April 1, 2026 12:32
RafaelGSS pushed a commit that referenced this pull request Apr 27, 2026
build: use CARGO environment variable if set
3fb47ed 
When enabling support for Temporal, check for the `CARGO` environment
variable to locate the `cargo` binary (defaulting to `cargo` if not
set) and use this to build `deps/crates`.

This will allow using Cargo on systems where the Cargo binary name is
suffixed with the version, e.g. `cargo-1.82` on Ubuntu 24.04.

PR-URL: #62421
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS mentioned this pull request Apr 27, 2026
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 28, 2026
build: use CARGO environment variable if set
a4edab8 
When enabling support for Temporal, check for the `CARGO` environment
variable to locate the `cargo` binary (defaulting to `cargo` if not
set) and use this to build `deps/crates`.

This will allow using Cargo on systems where the Cargo binary name is
suffixed with the version, e.g. `cargo-1.82` on Ubuntu 24.04.

PR-URL: #62421
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
legendecas legendecas approved these changes
RafaelGSS RafaelGSS approved these changes
marco-ippolito marco-ippolito approved these changes
+1 more reviewer
targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL