http: deprecate CRLF constant from _http_common - #62464
Closed
karan-lrn wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
karan-lrn
force-pushed
the
http-deprecate-crlf
branch
2 times, most recently
from
be7bf2a to
94c3e32
Compare
March 27, 2026 16:28
The CRLF constant exported from '_http_common' is deprecated (DEP0206). Users should use the string '\r\n' directly instead. This addresses the TODO comment added in nodejs#40101. PR-URL: https://github.com/nodejs/node/pull/XXXXX
karan-lrn
force-pushed
the
http-deprecate-crlf
branch
from
94c3e32 to
ef880b8
Compare
March 27, 2026 16:46
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #62464 +/- ##
==========================================
+ Coverage 89.70% 89.71% +0.01%
==========================================
Files 678 678
Lines 207260 207280 +20
Branches 39749 39749
==========================================
+ Hits 185917 185963 +46
+ Misses 13443 13427 -16
+ Partials 7900 7890 -10
... and 31 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
jasnell
requested changes
Mar 27, 2026
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I really don't see what purpose this serves.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
You're right - this doesn't provide much value. The CRLF constant is trivial and Thanks for the review! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRLF constant exported from '_http_common' is deprecated (DEP0206). Users should use the string '\r\n' directly instead.
This addresses the TODO comment added in #40101.
PR-URL: #62464