FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: add DCO sign-off check to commit workflow by jasnell · Pull Request #62473 · nodejs/node · GitHub

/ node Public

meta: add DCO sign-off check to commit workflow - #62473

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/require-signoff-workflow
ConversationCommits (1)ChecksFiles changed
Closed

meta: add DCO sign-off check to commit workflow#62473
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/require-signoff-workflow

Conversation

jasnell commented Mar 28, 2026

Copy link
Copy Markdown
Member

All commits are technically supposed to be signed off with a DCO sign-off (using Signed-off-by) but we haven't enforced that. We really ought to be.

Signed-off-by: James M Snell jasnell@gmail.com

meta: add DCO sign-off check to commit workflow
300d411 
All commits are technically supposed to be signed off
with a DCO sign-off (using `Signed-off-by`) but we
haven't enforced that. We really ought to be.

Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell requested review from mcollina and ruyadorno March 28, 2026 05:25

nodejs-github-bot commented Mar 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 28, 2026

mcollina commented Mar 28, 2026

Copy link
Copy Markdown
Member

This is best done via the DCO bot.

jasnell commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

Are you referring to https://github.com/apps/dco? If so, works for me.. I opened this solely as a nudge ;-)

mcollina commented Mar 28, 2026

Copy link
Copy Markdown
Member

That one!

jasnell commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

nodejs/admin#1053

jasnell closed this Mar 28, 2026
jasnell mentioned this pull request Mar 28, 2026
Closed

jasnell commented Mar 28, 2026

Copy link
Copy Markdown
Member Author

Reopening because there's some disagreement over whether we should use the bot @mcollina recommended.

jasnell requested a review from aduh95 March 28, 2026 15:43

aduh95 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

https://github.com/nodejs/core-validate-commit is where you want to add that

jasnell reopened this Mar 28, 2026
mcollina approved these changes Mar 28, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

aduh95 commented Mar 28, 2026

Copy link
Copy Markdown
Contributor

Closing in favor of nodejs/core-validate-commit#141

aduh95 closed this Mar 28, 2026
DivyanshuX9 mentioned this pull request May 24, 2026
Merged
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
ruyadorno Awaiting requested review from ruyadorno
aduh95 Awaiting requested review from aduh95

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL