FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: downgrade GCC support to experimental by targos · Pull Request #62533 · nodejs/node · GitHub

/ node Public

build: downgrade GCC support to experimental - #62533

Closed
targos wants to merge 1 commit into
nodejs:mainfrom
targos:default-clang
ConversationCommits (1)ChecksFiles changed
Closed

build: downgrade GCC support to experimental#62533
targos wants to merge 1 commit into
nodejs:mainfrom
targos:default-clang

Conversation

targos commented Apr 1, 2026

Copy link
Copy Markdown
Member

Update the configure script to select Clang by default.
V8 no longer officially supports GCC and we often have problems because of it.
Also bump the expected version to 13.2 because version 12 can't compile newer V8.

/cc @nodejs/build @nodejs/tsc @nodejs/embedders @nodejs/delivery-channels @nodejs/distros

Impacted CI systems:

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 1, 2026

nodejs-github-bot commented Apr 1, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/build
  • @nodejs/tsc

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. labels Apr 1, 2026
targos mentioned this pull request Apr 1, 2026
Merged

targos commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

The main goal is to unblock #61898 and future V8 updates.

build: downgrade GCC support to experimental
547f7be 
Update the configure script to select Clang by default.
V8 no longer officially supports GCC and we often have problems because
of it.
Also bump the expected version to 13.2 because version 12 can't compile
newer V8.

Signed-Off-By: Michaël Zasso <targos@protonmail.com>

MikeMcC399 commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Would it make more sense to deprecate GCC rather than move it to experimental? Or is there an expectation that the "experimental" flag could be removed, even though the following is stated?

V8 no longer officially supports GCC

targos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026
aduh95 reviewed Apr 1, 2026
View reviewed changes
Comment thread .github/workflows/build-tarball.yml
Comment on lines +80 to +83
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

aduh95 Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This job only packs the tarball, the actual compilation already uses clang

Suggested change
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

targos Apr 1, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

If clang is not installed, the new default in configure.py makes it fail. See https://github.com/nodejs/node/actions/runs/23843452764/job/69504716314?pr=62533

aduh95 Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can we add a flag to disable that check:

diff --git a/configure.py b/configure.py
index 6182537bfa..49a99767a9 100755
--- a/configure.py
+++ b/configure.py
@@ -2607,7 +2607,8 @@ configurations = {
 }
 
 # Print a warning when the compiler is too old.
-check_compiler(output)
+if not os.environ['SKIP_COMPILER_CHECK']:
+  check_compiler(output)
 
 # determine the "flavor" (operating system) we're building for,
 # leveraging gyp's GetFlavor function

aduh95 reviewed Apr 1, 2026
View reviewed changes
Comment thread .github/workflows/build-tarball.yml
Comment on lines +97 to +99
env:
CC: clang-19
CXX: clang++-19

aduh95 Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
env:
CC: clang-19
CXX: clang++-19

aduh95 reviewed Apr 1, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml
Comment on lines +123 to +127
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

aduh95 Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
- name: Install Clang ${{ env.CLANG_VERSION }}
uses: ./.github/actions/install-clang
with:
clang-version: ${{ env.CLANG_VERSION }}

aduh95 reviewed Apr 1, 2026
View reviewed changes
Comment thread .github/workflows/test-shared.yml
Comment on lines +136 to +137
CC: clang-19
CXX: clang++-19

aduh95 Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality
Suggested change
CC: clang-19
CXX: clang++-19

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2026

This comment was marked as outdated.

Sign in to view

joyeecheung commented Apr 1, 2026

Copy link
Copy Markdown
Member

The main goal is to unblock #61898 and future V8 updates.

I think the GCC support for 61898 was already unblocked by https://chromium-review.googlesource.com/c/v8/v8/+/7666244 and the remaining blocker seems unrelated? (I think the remaining blocker is similar to something else I fixed for the previous upgrade, most likely a legit bug in V8's transitions management)

targos commented Apr 1, 2026

Copy link
Copy Markdown
Member Author

The current GCC issue is something else: #61898 (comment)

joyeecheung commented Apr 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

The current GCC issue is something else

It seems specific to GCC 12? I feel that we could split the discussion separately: bumping GCC support to 13 (12 already reached EOL last year, so this seems less disruptive), and moving GCC to experimental on all platforms, which can cause more disruption, especially considering addons and downstream distros - it would be unfortunate to disrupt Linux distros just because an EOL version of GCC doesn't work on AIX - at least keeping an up-to-date version of GCC on Linux supported is good ROI, and V8 is generally happy to take patches to keep that working

targos commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

I agree with you, but in practice, I am close to giving up on my usual task of updating V8 mainly because of GCC. Until recently, it's been relatively OK because IBM still often submitted compatibility patches to make it work for AIX, but this is going to stop since they switched to Clang. I'll open another PR to only bump the minimum version.

targos commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

#62555

1 similar comment

targos commented Apr 2, 2026

Copy link
Copy Markdown
Member Author

#62555

mcollina approved these changes Apr 2, 2026
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72421/

joyeecheung commented Apr 2, 2026

Copy link
Copy Markdown
Member

I reached out a bit and I can confirm I (and maybe with additional hands) could help keep a non-EOL version of GCC + x64 Linux build supported at least in the foreseeable future - we could keep it working via GHA in the main repo and in canary to reduce the churn in V8 updates. Can we keep this configuration as supported in BUILDING.md and in the actions?

targos closed this Apr 3, 2026

targos commented Apr 3, 2026

Copy link
Copy Markdown
Member Author

we could keep it working via GHA in the main repo and in canary to reduce the churn in V8 updates

If there's an efficient way to get it fixed in advance, that would be awesome.
Canary has been broken for weeks on GCC 14: nodejs/node-v8#305 / https://github.com/nodejs/node-v8/actions/runs/23936830469

joyeecheung commented Apr 3, 2026

Copy link
Copy Markdown
Member

Thanks for the pointer, I'll take a look

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

aduh95 aduh95 left review comments
mcollina mcollina approved these changes
panva panva approved these changes
jasnell jasnell approved these changes
anonrig anonrig approved these changes

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL