[v24.x backport] wasm: support js string constant esm import - #62569
Closed
guybedford wants to merge 2 commits into
Closed
[v24.x backport] wasm: support js string constant esm import#62569guybedford wants to merge 2 commits into
guybedford wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
PR-URL: nodejs#62415 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Extends the Wasm ESM Integration for importing WebAssembly modules in either the source phase or instance phase to support importing static JS string constants from the special import name `wasm:js/string-constants`. PR-URL: nodejs#62198 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v24.x-staging #62569 +/- ##
================================================
Coverage 90.10% 90.11%
================================================
Files 667 670 +3
Lines 199019 200418 +1399
Branches 38911 39103 +192
================================================
+ Hits 179335 180610 +1275
- Misses 12040 12135 +95
- Partials 7644 7673 +29
... and 170 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Same as in #62568 (comment) – also FYI if we have to have backport PRs, it's easier for us to bunch the backports, i.e. putting all the related commits in the same backport PR (which this one is doing, but since you also opened #62568, you thought you might not know) |
Sorry, something went wrong.
aduh95
force-pushed
the
v24.x-staging
branch
2 times, most recently
from
24fd6c2 to
c167630
Compare
April 6, 2026 10:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62198 for 24.x.