http: reject addTrailers after finish - #62832
Merged
nodejs-github-bot merged 1 commit intoApr 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
islandryu
force-pushed
the
fix-addtrailers-after-finish
branch
from
b054c33 to
aa9f6c0
Compare
April 19, 2026 14:04
islandryu
force-pushed
the
fix-addtrailers-after-finish
branch
from
aa9f6c0 to
265df15
Compare
April 19, 2026 14:34
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #62832 +/- ##
==========================================
+ Coverage 88.54% 89.67% +1.12%
==========================================
Files 703 706 +3
Lines 208544 218226 +9682
Branches 40225 41777 +1552
==========================================
+ Hits 184648 195685 +11037
+ Misses 15903 14457 -1446
- Partials 7993 8084 +91
... and 419 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
ShogunPanda
approved these changes
Apr 19, 2026
mcollina
approved these changes
Apr 19, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
bjohansebas
approved these changes
Apr 19, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
pimterry
approved these changes
Apr 20, 2026
lpinca
approved these changes
Apr 20, 2026
metcoder95
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #62809