lib: reject SharedArrayBuffer in Blob constructor per spec - #63046
Merged
nodejs-github-bot merged 1 commit intoMay 4, 2026
Merged
lib: reject SharedArrayBuffer in Blob constructor per spec#63046nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63046 +/- ##
=======================================
Coverage 89.63% 89.63%
=======================================
Files 708 708
Lines 220402 220408 +6
Branches 42271 42276 +5
=======================================
+ Hits 197551 197559 +8
+ Misses 14706 14700 -6
- Partials 8145 8149 +4
... and 28 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
aduh95
approved these changes
Apr 30, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Renegade334
approved these changes
Apr 30, 2026
Renegade334
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Thanks for this.
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
cc @nodejs/tsc for semver-major approval. |
Sorry, something went wrong.
anonrig
approved these changes
May 4, 2026
mcollina
approved these changes
May 4, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the remaining piece of the work tracked in #59688. The Blob change is semver-major because today the call succeeds.
The shared BufferSource converter was made hot-path-friendly in #62833, so no per-call binding overhead is added here.
Refs: #59688
Refs: #62632