FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: add temporary workaround for Rust on macOS by richardlau · Pull Request #63053 · nodejs/node · GitHub

/ node Public

build: add temporary workaround for Rust on macOS - #63053

Closed
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:macosrust-workaround
ConversationCommits (1)ChecksFiles changed
Closed

build: add temporary workaround for Rust on macOS#63053
richardlau wants to merge 1 commit into
nodejs:mainfrom
richardlau:macosrust-workaround

Conversation

richardlau commented Apr 30, 2026

Copy link
Copy Markdown
Member

Temporarily install the x64 Rust target on macOS at build time. To be removed when the target is installed at the macOS VM level.

Refs: #63015
Refs: nodejs/build#4316

This can land independently of nodejs/build#4316, but if it does land it should be reverted once nodejs/build#4316 is deployed onto the macOS VMs.

build: add temporary workaround for Rust on macOS
6782821 
Temporarily install the x64 Rust target on macOS at build time.
To be removed when the target is installed at the macOS VM level.

Signed-off-by: Richard Lau <richard.lau@ibm.com>
richardlau added build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels Apr 30, 2026
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 30, 2026

richardlau commented Apr 30, 2026

Copy link
Copy Markdown
Member Author

Test pkg build: https://ci-release.nodejs.org/job/iojs+release/11744/nodes=macos15-release-pkg/

richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 30, 2026

nodejs-github-bot commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73052/

sxa self-assigned this Apr 30, 2026
sxa reviewed Apr 30, 2026
View reviewed changes

sxa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I approve in principle but will hold off on any formal approve/merge until @ryanaslett and I can determine if this change can be made on the orka images tomorrow.

codecov Bot commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.65%. Comparing base (66054cc) to head (6782821).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63053      +/-   ##
==========================================
- Coverage   91.48%   89.65%   -1.84%     
==========================================
  Files         358      708     +350     
  Lines      151591   220410   +68819     
  Branches    23925    42276   +18351     
==========================================
+ Hits       138690   197598   +58908     
- Misses      12625    14659    +2034     
- Partials      276     8153    +7877

see 473 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73053/

sxa commented May 1, 2026

Copy link
Copy Markdown
Member

I'm going to close this now as we've built and redeployed an updated image including this by dwefault via nodejs/build#4316 and it has successful run in

sxa closed this May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

sxa sxa left review comments
anonrig anonrig approved these changes
aduh95 aduh95 approved these changes
RafaelGSS RafaelGSS approved these changes
gurgunday gurgunday approved these changes

Assignees

sxa

Labels

build Issues and PRs related to build files or the CI. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. macos Issues and PRs related to the macOS platform / OSX. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL