tools: filter V8 scripts for build toolchain - #63069
Merged
nodejs-github-bot merged 1 commit intoMay 13, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Patch the build scripts for V8 when running the V8 CI for Linux on ppc64le and s390x to workaround inconsistencies between the nightly build toolchain used by V8 and the released versions that we use from the Linux distribution. Signed-off-by: Richard Lau <richard.lau@ibm.com>
Copy link
Copy Markdown
Member
Author
|
Several force pushes to satisfy the sh linter. Test runs:
|
Sorry, something went wrong.
joyeecheung
approved these changes
May 1, 2026
targos
approved these changes
May 2, 2026
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63069 ✔ Done loading data for nodejs/node/pull/63069 ----------------------------------- PR info ------------------------------------ Title tools: filter V8 scripts for build toolchain (#63069) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch richardlau:makev8 -> nodejs:main Labels v8 engine, tools, needs-ci, dont-land-on-v22.x, dont-land-on-v24.x, dont-land-on-v25.x Commits 1 - tools: filter V8 scripts for build toolchain Committers 1 - Richard Lau <richard.lau@ibm.com> PR-URL: https://github.com/nodejs/node/pull/63069 Refs: https://github.com/ibmruntimes/v8-build/blob/49b55c036da148bd18b546f19b731a0fe92b6a33/bin/v8.sh#L62-L71 Refs: https://github.com/nodejs/build/issues/4265 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63069 Refs: https://github.com/ibmruntimes/v8-build/blob/49b55c036da148bd18b546f19b731a0fe92b6a33/bin/v8.sh#L62-L71 Refs: https://github.com/nodejs/build/issues/4265 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 01 May 2026 15:55:44 GMT ✔ Approvals: 2 ✔ - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/63069#pullrequestreview-4213602852 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/63069#pullrequestreview-4214476644 ✔ Last GitHub CI successful ✘ No full Jenkins CI runs detected ℹ Last V8 CI on 2026-05-01T17:02:41Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/7169/ - Querying data for job/node-test-pull-request/7169/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/25675882689 |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Patch the build scripts for V8 when running the V8 CI for Linux on ppc64le and s390x to workaround inconsistencies between the nightly build toolchain used by V8 and the released versions that we use from the Linux distribution. Signed-off-by: Richard Lau <richard.lau@ibm.com> PR-URL: #63069 Refs: https://github.com/ibmruntimes/v8-build/blob/49b55c036da148bd18b546f19b731a0fe92b6a33/bin/v8.sh#L62-L71 Refs: nodejs/build#4265 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Patch the build scripts for V8 when running the V8 CI for Linux on ppc64le and s390x to workaround inconsistencies between the nightly build toolchain used by V8 and the released versions that we use from the Linux distribution. Signed-off-by: Richard Lau <richard.lau@ibm.com> PR-URL: #63069 Refs: https://github.com/ibmruntimes/v8-build/blob/49b55c036da148bd18b546f19b731a0fe92b6a33/bin/v8.sh#L62-L71 Refs: nodejs/build#4265 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patch the build scripts for V8 when running the V8 CI for Linux on ppc64le and s390x to workaround inconsistencies between the nightly build toolchain used by V8 and the released versions that we use from the Linux distribution.
Refs: #62572 (comment)
Refs: https://github.com/ibmruntimes/v8-build/blob/49b55c036da148bd18b546f19b731a0fe92b6a33/bin/v8.sh#L62-L71
Refs: nodejs/build#4265
Opening this as separate from the V8 14.8 update as I want to cherry-pick it across to v26.x. The plan is to update clang and rustc on the RHEL machines and this patch should keep the V8 CI working on v26.x and main during the transition. Without this patch V8 CI would break on Linux on ppc64le and s390x when we update Rust to 1.88 as "adler" has been replaced with "adler2".