lib,src: updates for BoringSSL - #63125
Closed
panva wants to merge 6 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
panva
force-pushed
the
make-crypto-boring-again
branch
2 times, most recently
from
121a7ab to
97a3c8f
Compare
May 5, 2026 13:30
This comment was marked as outdated.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 90.24390% with 8 lines in your changes missing coverage. Please review. @@ Coverage Diff @@
## main #63125 +/- ##
==========================================
- Coverage 90.03% 90.03% -0.01%
==========================================
Files 713 713
Lines 224950 224969 +19
Branches 42532 42560 +28
==========================================
+ Hits 202542 202552 +10
- Misses 14175 14180 +5
- Partials 8233 8237 +4
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
panva
force-pushed
the
make-crypto-boring-again
branch
from
97a3c8f to
6b8d741
Compare
May 5, 2026 15:49
This comment was marked as outdated.
panva
force-pushed
the
make-crypto-boring-again
branch
from
6b8d741 to
db65e65
Compare
May 5, 2026 17:17
This comment was marked as outdated.
panva
force-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
078d5ed to
b88eca8
Compare
May 6, 2026 19:13
jasnell
approved these changes
May 7, 2026
jasnell
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM but would be good to have @codebytere also take a look if they're available to do so.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
This is WIP / CI harness @jasnell . I am slowly taking things off the stack here and opening them individually. E.g. #63161 |
Sorry, something went wrong.
panva
force-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
8868f43 to
b2b116e
Compare
May 8, 2026 08:53
aduh95
reviewed
May 8, 2026
Comment thread
tools/dep_updaters/update-nixpkgs-pin.sh
Outdated
panva
force-pushed
the
make-crypto-boring-again
branch
3 times, most recently
from
2a7cae8 to
cd86c6a
Compare
May 8, 2026 18:12
BoringSSL declares EVP_CIPHER_do_all_sorted and EVP_MD_do_all_sorted, but stock no-decrepit builds do not provide those symbols. Add a Node build flag that keeps ncrypto and its dependents on a local BoringSSL fallback list when libdecrepit is absent. Keep embedders that provide the EVP enumeration symbols on the normal OpenSSL-compatible path, matching Electron's patched BoringSSL build. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by OpenSSL version and use those instead of repeating version checks. Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva
force-pushed
the
make-crypto-boring-again
branch
from
cd86c6a to
02d372e
Compare
May 8, 2026 23:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wip Issues and PRs that are still a work in progress.