FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: remove unused using declarations in node_task_queue by mertcanaltin · Pull Request #63144 · nodejs/node · GitHub

/ node Public

src: remove unused using declarations in node_task_queue - #63144

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
mertcanaltin:mert/fix-task-queue-unused-using
May 6, 2026
Merged

src: remove unused using declarations in node_task_queue#63144
aduh95 merged 2 commits into
nodejs:mainfrom
mertcanaltin:mert/fix-task-queue-unused-using

Conversation

Copy link
Copy Markdown
Member

Leftover from #62336 which removed the references but kept the using declarations. tools/checkimports.py flags them as unused on every CI run.

Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 6, 2026
panva added the fast-track PRs that do not need to wait for 48 hours to land. label May 6, 2026

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

Copy link
Copy Markdown
Collaborator

panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. and removed author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels May 6, 2026
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 6, 2026

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

codecov Bot commented May 6, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.67%. Comparing base (1aebbde) to head (7371123).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63144      +/-   ##
==========================================
- Coverage   91.48%   89.67%   -1.81%     
==========================================
  Files         361      713     +352     
  Lines      155193   224076   +68883     
  Branches    23949    42311   +18362     
==========================================
+ Hits       141977   200947   +58970     
- Misses      12943    14951    +2008     
- Partials      273     8178    +7905     
Files with missing lines Coverage Δ
src/node_task_queue.cc 83.01% <100.00%> (ø)

... and 471 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 6, 2026
aduh95 merged commit e80b5d2 into nodejs:main May 6, 2026
86 of 91 checks passed

aduh95 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Landed in e80b5d2

aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
PR-URL: #63144
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: Mert Can Altin <mertgold60@gmail.com>
PR-URL: #63144
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL