Revert "quic: complete the internal implementation of QUIC" - #63148
Closed
aduh95 wants to merge 1 commit into
Closed
Revert "quic: complete the internal implementation of QUIC"#63148aduh95 wants to merge 1 commit into
aduh95 wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit cf91d18. Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
panva
approved these changes
May 6, 2026
pimterry
approved these changes
May 6, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 61.15385% with 101 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63148 +/- ##
==========================================
+ Coverage 89.66% 89.69% +0.03%
==========================================
Files 713 712 -1
Lines 224076 221240 -2836
Branches 42308 42387 +79
==========================================
- Hits 200912 198446 -2466
+ Misses 14996 14616 -380
- Partials 8168 8178 +10
... and 63 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Simpler Alternative: #63149 |
Sorry, something went wrong.
jasnell
requested changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #62876 (comment), without this revert coverage GHA job always fail, preventing other PRs to land