FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix test-vm-cached-data to work with old v8 by MylesBorins · Pull Request #6317 · nodejs/node · GitHub

/ node Public

test: fix test-vm-cached-data to work with old v8 - #6317

Merged
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:fix-vm-cached-data
May 11, 2016
ConversationCommits (1)ChecksFiles changed
Merged

test: fix test-vm-cached-data to work with old v8#6317
MylesBorins merged 1 commit into
nodejs:masterfrom
MylesBorins:fix-vm-cached-data

Conversation

MylesBorins commented Apr 20, 2016

Copy link
Copy Markdown
Contributor

while let no longer needs to run in strict mode in v8 5.x it throws
in v8 4. This modification will make the test-vm-cached-data work in
older version of node.

I am under the impression that these changes were made to test features that will only be available in v8 5. So perhaps we don't care to support older versions. Either way it might be nice to be explicit with the code being shelled out.

I've currently marked #6280 as dont-land-on-v5.x, but we can change that if this lands

/cc @jasnell @indutny

MylesBorins added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels Apr 20, 2016

jasnell commented Apr 20, 2016

Copy link
Copy Markdown
Member

hmm... not sure there's enough value at this point with v6 right around the corner. If we were going to pull this back to v4 then I think I'd be +1 for sure.

MylesBorins commented Apr 20, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell I figured we would probably not want it... but had already made the patch and it was small enough I figured we might want to be explicit

jasnell commented Apr 20, 2016

Copy link
Copy Markdown
Member

this would need to be rebased now ;-)

estliberitas force-pushed the master branch 2 times, most recently from 7da4fd4 to c7066fb Compare April 26, 2016 05:23

MylesBorins commented Apr 27, 2016

Copy link
Copy Markdown
Contributor Author

@jasnell rebased

bnoordhuis commented Apr 28, 2016

Copy link
Copy Markdown
Member

LGTM but can you capitalize 'while' and use 'Refs:' in the commit log?

indutny commented Apr 28, 2016

Copy link
Copy Markdown
Member

LGTM, but may be we should just turn the only let here to var instead?

MylesBorins force-pushed the fix-vm-cached-data branch 2 times, most recently from e70f2cc to 43166c0 Compare May 9, 2016 20:34

MylesBorins commented May 9, 2016

Copy link
Copy Markdown
Contributor Author

I've updated with both of your suggestions @bnoordhuis / @indutny

PTAL and let me know if this is ok

indutny commented May 9, 2016

Copy link
Copy Markdown
Member

LGTM

2 similar comments

bnoordhuis commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM

targos commented May 10, 2016

Copy link
Copy Markdown
Member

LGTM

MylesBorins force-pushed the fix-vm-cached-data branch from 43166c0 to e26f1e7 Compare May 11, 2016 19:06
test: fix test-vm-cached-data to work with old v8
9460b20 
While `let` no longer needs to run in `strict mode` in v8 5.x it throws
in v8 4. This modification will make the test-vm-cached-data work in
older version of node.

Refs: nodejs#6280

PR-URL: nodejs#6317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
MylesBorins force-pushed the fix-vm-cached-data branch from e26f1e7 to 9460b20 Compare May 11, 2016 19:07
MylesBorins merged commit 9460b20 into nodejs:master May 11, 2016
MylesBorins deleted the fix-vm-cached-data branch May 12, 2016 18:14
evanlucas pushed a commit that referenced this pull request May 17, 2016
test: fix test-vm-cached-data to work with old v8
1b71231 
While `let` no longer needs to run in `strict mode` in v8 5.x it throws
in v8 4. This modification will make the test-vm-cached-data work in
older version of node.

Refs: #6280

PR-URL: #6317
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
evanlucas mentioned this pull request May 17, 2016
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL