[v24.x backport] crypto: remove Argon2 KDF derivation from its job setup - #63170
Closed
panva wants to merge 1 commit into
Closed
[v24.x backport] crypto: remove Argon2 KDF derivation from its job setup#63170panva wants to merge 1 commit into
panva wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Fixes: nodejs#62861 Signed-off-by: Filip Skokan <panva.ip@gmail.com> PR-URL: nodejs#62863 Fixes: nodejs#62861 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Will open 1 PR for multiple backports as requested. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## v24.x-staging #63170 +/- ##
================================================
Coverage 90.06% 90.07%
================================================
Files 672 675 +3
Lines 201174 203742 +2568
Branches 39304 39910 +606
================================================
+ Hits 181197 183520 +2323
- Misses 12240 12427 +187
- Partials 7737 7795 +58
... and 194 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #62861 for v24.x, the only change is the expected error message (which depended on #62348 semver-major PRs that contain breaking changes and should be released in the next major version. )