FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: support --allow-net permissions by jasnell · Pull Request #63184 · nodejs/node · GitHub

/ node Public

quic: support --allow-net permissions - #63184

Closed
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-perms
Closed

quic: support --allow-net permissions#63184
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/quic-perms

Conversation

jasnell commented May 8, 2026

Copy link
Copy Markdown
Member

Enable use of --allow-net with the quic impl

@nodejs/quic

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
  • @nodejs/security-wg

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels May 8, 2026

This comment was marked as outdated.

This comment was marked as outdated.

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 8, 2026

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

RafaelGSS added the permission Issues and PRs related to the Permission Model label May 8, 2026

This comment was marked as outdated.

jasnell force-pushed the jasnell/quic-perms branch from d30f7d3 to b367d65 Compare May 9, 2026 22:31
jasnell added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 9, 2026

This comment was marked as outdated.

jasnell force-pushed the jasnell/quic-perms branch from b367d65 to 97dd5c5 Compare May 9, 2026 22:45

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

bjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

jasnell force-pushed the jasnell/quic-perms branch from 97dd5c5 to 8fe3a4d Compare May 11, 2026 02:38

This comment was marked as outdated.

This comment was marked as outdated.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
jasnell force-pushed the jasnell/quic-perms branch from 8fe3a4d to f0d5c31 Compare May 11, 2026 13:48

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

jasnell added a commit that referenced this pull request May 11, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: #63184
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>

jasnell commented May 11, 2026

Copy link
Copy Markdown
Member Author

Landed in 58cd0b8

jasnell closed this May 11, 2026
aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: #63184
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 pushed a commit that referenced this pull request May 19, 2026
Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode:Opus 4.6
PR-URL: #63184
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL