[v22.x backport] doc: remove obsolete Boxstarter automated install - #63190
[v22.x backport] doc: remove obsolete Boxstarter automated install#63190MikeMcC399 wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
PR-URL: nodejs#61785 Fixes: nodejs#61690 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
|
I have added Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
to satisfy linting, despite what it says in https://github.com/nodejs/node/blob/main/doc/contributing/pull-requests.md#step-4-commit that it is not required for backport commits. |
Sorry, something went wrong.
|
@MikeMcC399 as per the backport rule I believe we should not change commit message also, it's fine to let if fail for now node/doc/contributing/pull-requests.md Lines 207 to 208 in e15f905 |
Sorry, something went wrong.
|
Since I was the author also of the original PR that I am backporting, and at the time the original PR was submitted and landed there was no requirement for Signed-off-by, I'm fine to add this now as a workaround. I've added a separate issue #63192 to clarify the linting / process problem. I would only remove the Signed-off-by trailer if it causes an issue to leave it in and I defer to the backporters team for any instructions they want to give. |
Sorry, something went wrong.
PR-URL: #61785 Backport-PR-URL: #63190 Fixes: #61690 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Tierney Cyren <hello@bnb.im> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Signed-off-by: Mike McCready <66998419+MikeMcC399@users.noreply.github.com>
Backports #61785 to v22.x
PR-URL: #61785
Fixes: #61690
Reviewed-By: Richard Lau richard.lau@ibm.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com
Reviewed-By: Stefan Stojanovic stefan.stojanovic@janeasystems.com
Reviewed-By: Tierney Cyren hello@bnb.im
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Rafael Gonzaga rafael.nunu@hotmail.com