| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
Review requested:
|
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63191 +/- ##
==========================================
+ Coverage 90.03% 90.08% +0.04%
==========================================
Files 713 714 +1
Lines 224510 225759 +1249
Branches 42438 42734 +296
==========================================
+ Hits 202148 203367 +1219
- Misses 14163 14193 +30
Partials 8199 8199
... and 100 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
|
FYI ignore the pummel failures on aix73-power9 - that's unrelated to this PR. I just switched on that axis this morning and have disabled again while it's investigated. |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Commit Queue failed- Loading data for nodejs/node/pull/63191 ✔ Done loading data for nodejs/node/pull/63191 ----------------------------------- PR info ------------------------------------ Title quic: expose QUIC certificates as JS X509Certificate, not raw handles (#63191) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch pimterry:fix-quic-peer-certificate -> nodejs:main Labels needs-ci, quic, commit-queue-squash Commits 2 - quic: expose QUIC certificates as JS X509Certificate, not raw handles - Fix no-crypto builds Committers 1 - Tim Perry <pimterry@gmail.com> PR-URL: https://github.com/nodejs/node/pull/63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 May 2026 11:13:00 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63191#pullrequestreview-4252294171 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/63191#pullrequestreview-4299399955 ✔ - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63191#pullrequestreview-4334550569 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-05-21T15:55:03Z: https://ci.nodejs.org/job/node-test-pull-request/73605/ - Querying data for job/node-test-pull-request/73605/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 63191 From https://github.com/nodejs/node * branch refs/pull/63191/merge -> FETCH_HEAD ✔ Fetched commits as f835cc42da4e..a19198458c31 -------------------------------------------------------------------------------- Auto-merging doc/api/quic.md Auto-merging lib/internal/quic/quic.js CONFLICT (content): Merge conflict in lib/internal/quic/quic.js error: could not apply 4478d4ba7e... quic: expose QUIC certificates as JS X509Certificate, not raw handles hint: After resolving the conflicts, mark them with hint: "git add/rm <pathspec>", then run hint: "git cherry-pick --continue". hint: You can instead skip this commit with "git cherry-pick --skip". hint: To abort and get back to the state before "git cherry-pick", hint: run "git cherry-pick --abort". ✘ Failed to apply patcheshttps://github.com/nodejs/node/actions/runs/26253721782 |
Sorry, something went wrong.
Signed-off-by: Tim Perry <pimterry@gmail.com>
|
Just spotted this, I think the commit-queue raced with another QUIC PR and ended up conflicted. Now rebased and resolved, no other changes. I'd love a re-review please if anybody has a sec, and then this can get moving again. |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM!
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
| Back | FazBrowse Home | New Git URL |
Starting to work through the TLS implementation in QUIC, one nice small standalone fix here.