FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

quic: expose QUIC certificates as JS X509Certificate, not raw handles by pimterry · Pull Request #63191 · nodejs/node · GitHub

/ node Public

quic: expose QUIC certificates as JS X509Certificate, not raw handles - #63191

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
pimterry:fix-quic-peer-certificate
Jun 20, 2026
Merged

quic: expose QUIC certificates as JS X509Certificate, not raw handles#63191
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
pimterry:fix-quic-peer-certificate

Conversation

pimterry commented May 8, 2026

Copy link
Copy Markdown
Member

Starting to work through the TLS implementation in QUIC, one nice small standalone fix here.

pimterry requested a review from jasnell May 8, 2026 11:13

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic

nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3. labels May 8, 2026
pimterry force-pushed the fix-quic-peer-certificate branch from 13e1c27 to 4478d4b Compare May 8, 2026 11:28

codecov Bot commented May 8, 2026
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (b5da751) to head (a191984).
⚠️ Report is 155 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63191      +/-   ##
==========================================
+ Coverage   90.03%   90.08%   +0.04%     
==========================================
  Files         713      714       +1     
  Lines      224510   225759    +1249     
  Branches    42438    42734     +296     
==========================================
+ Hits       202148   203367    +1219     
- Misses      14163    14193      +30     
  Partials     8199     8199              
Files with missing lines Coverage Δ
lib/internal/quic/quic.js 100.00% <100.00%> (ø)

... and 100 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

pimterry force-pushed the fix-quic-peer-certificate branch from b19cc4c to a191984 Compare May 18, 2026 14:52
pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 21, 2026

Copy link
Copy Markdown
Collaborator

sxa commented May 21, 2026

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/73598/

FYI ignore the pummel failures on aix73-power9 - that's unrelated to this PR. I just switched on that axis this morning and have disabled again while it's investigated.

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

pimterry added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 21, 2026
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 21, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/63191
✔  Done loading data for nodejs/node/pull/63191
----------------------------------- PR info ------------------------------------
Title      quic: expose QUIC certificates as JS X509Certificate, not raw handles (#63191)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     pimterry:fix-quic-peer-certificate -> nodejs:main
Labels     needs-ci, quic, commit-queue-squash
Commits    2
 - quic: expose QUIC certificates as JS X509Certificate, not raw handles
 - Fix no-crypto builds
Committers 1
 - Tim Perry <pimterry@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 08 May 2026 11:13:00 GMT
   ✔  Approvals: 3
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63191#pullrequestreview-4252294171
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/63191#pullrequestreview-4299399955
   ✔  - Stephen Belanger (@Qard): https://github.com/nodejs/node/pull/63191#pullrequestreview-4334550569
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-05-21T15:55:03Z: https://ci.nodejs.org/job/node-test-pull-request/73605/
- Querying data for job/node-test-pull-request/73605/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63191
From https://github.com/nodejs/node
 * branch                  refs/pull/63191/merge -> FETCH_HEAD
✔  Fetched commits as f835cc42da4e..a19198458c31
--------------------------------------------------------------------------------
Auto-merging doc/api/quic.md
Auto-merging lib/internal/quic/quic.js
CONFLICT (content): Merge conflict in lib/internal/quic/quic.js
error: could not apply 4478d4ba7e... quic: expose QUIC certificates as JS X509Certificate, not raw handles
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
   ✘  Failed to apply patches
https://github.com/nodejs/node/actions/runs/26253721782

pimterry force-pushed the fix-quic-peer-certificate branch from a191984 to c6711a1 Compare June 15, 2026 11:44

Copy link
Copy Markdown
Member Author

Just spotted this, I think the commit-queue raced with another QUIC PR and ended up conflicted.

Now rebased and resolved, no other changes. I'd love a re-review please if anybody has a sec, and then this can get moving again.

bjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM!

pimterry added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2026
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2026

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

pimterry added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 20, 2026
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2026
nodejs-github-bot merged commit 6d5a085 into nodejs:main Jun 20, 2026
79 of 80 checks passed

Copy link
Copy Markdown
Collaborator

Landed in 6d5a085

aduh95 pushed a commit that referenced this pull request Jun 20, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit to aduh95/node that referenced this pull request Aug 3, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: nodejs#63191
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
Signed-off-by: Tim Perry <pimterry@gmail.com>
PR-URL: #63191
Backport-PR-URL: #64675
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC implementation / HTTP/3.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL