stream: cache minimum cursor count in share - #63262
Merged
nodejs-github-bot merged 4 commits intoMay 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
trivikr
force-pushed
the
streams-iter-share
branch
2 times, most recently
from
a0ce67e to
8a32f1c
Compare
May 12, 2026 06:51
This comment was marked as outdated.
Renegade334
reviewed
May 12, 2026
Comment thread
lib/internal/streams/iter/broadcast.js
Outdated
Comment thread
lib/internal/streams/iter/share.js
Outdated
Comment thread
lib/internal/streams/iter/share.js
Outdated
Renegade334
reviewed
May 12, 2026
Comment thread
lib/internal/streams/iter/share.js
trivikr
marked this pull request as ready for review
May 12, 2026 08:02
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 85.15625% with 19 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63262 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 714 714
Lines 225247 225338 +91
Branches 42578 42597 +19
=======================================
+ Hits 202842 202930 +88
- Misses 14181 14190 +9
+ Partials 8224 8218 -6
... and 33 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Track the number of consumers at the cached minimum cursor in share() so the minimum is only recomputed when the last consumer at that cursor advances or detaches. This avoids scanning every consumer on each trim attempt when multiple consumers advance through a shared buffer. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
streams-iter-share
branch
from
2eda9ba to
f843e46
Compare
May 13, 2026 15:20
jasnell
approved these changes
May 14, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Renegade334
approved these changes
May 14, 2026
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Track the number of consumers at the cached minimum cursor in share() so the minimum is only recomputed when the last consumer at that cursor advances or detaches. This avoids scanning every consumer on each trim attempt when multiple consumers advance through a shared buffer. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Track the number of consumers at the cached minimum cursor in share() so the minimum is only recomputed when the last consumer at that cursor advances or detaches. This avoids scanning every consumer on each trim attempt when multiple consumers advance through a shared buffer. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Track the number of consumers at the cached minimum cursor in share() so the minimum is only recomputed when the last consumer at that cursor advances or detaches. This avoids scanning every consumer on each trim attempt when multiple consumers advance through a shared buffer. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63262 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Track the number of consumers at the cached minimum cursor in share() so the minimum is only recomputed when the last consumer at that cursor advances or detaches. This avoids scanning every consumer on each trim attempt when multiple consumers advance through a shared buffer. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63262 Backport-PR-URL: #64675 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This updates share() and shareSync() to avoid recomputing the minimum
consumer cursor on every buffer trim attempt.
Instead of scanning all consumers each time, share now caches the current
minimum cursor and tracks how many consumers are positioned at that
cursor. The minimum is recomputed only when the last consumer at the
cached minimum advances or detaches.
The shared getMinCursor() utility now returns both the minimum cursor
and the number of consumers at that cursor.
Benchmark
Assisted-by: openai:gpt-5.5