stream: preserve toReadableSync batch after backpressure - #63276
Merged
nodejs-github-bot merged 1 commit intoMay 15, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Keep the current batch and index across _read() calls so chunks that remain after push() returns false are emitted on later reads. Fixes: nodejs#63275 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
mcollina
approved these changes
May 13, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63276 +/- ##
========================================
Coverage 90.04% 90.05%
========================================
Files 713 714 +1
Lines 225003 225256 +253
Branches 42536 42573 +37
========================================
+ Hits 202606 202849 +243
- Misses 14177 14181 +4
- Partials 8220 8226 +6
... and 39 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 13, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
jasnell
approved these changes
May 14, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Keep the current batch and index across _read() calls so chunks that remain after push() returns false are emitted on later reads. Fixes: #63275 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63276 Fixes: #63275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
Keep the current batch and index across _read() calls so chunks that remain after push() returns false are emitted on later reads. Fixes: #63275 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63276 Fixes: #63275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Keep the current batch and index across _read() calls so chunks that remain after push() returns false are emitted on later reads. Fixes: nodejs#63275 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63276 Fixes: nodejs#63275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Keep the current batch and index across _read() calls so chunks that remain after push() returns false are emitted on later reads. Fixes: #63275 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63276 Backport-PR-URL: #64675 Fixes: #63275 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toReadableSync() could drop chunks from a batch when classic stream
backpressure was applied.
When _read() pulled a batch with multiple chunks and push() returned
false, the method returned immediately without saving the remaining batch
items. A later _read() call advanced to the next iterator result, so the
unpushed chunks were lost.
This stores the current batch and index across _read() calls, allowing
toReadableSync() to resume the same batch after backpressure clears.
Fixes: #63275
Assisted-by: openai:gpt-5.5