stream: avoid retrying accepted pipeTo writes - #63297
Merged
nodejs-github-bot merged 2 commits intoMay 16, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
jasnell
approved these changes
May 14, 2026
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 90.90909% with 4 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63297 +/- ##
=======================================
Coverage 90.05% 90.06%
=======================================
Files 714 714
Lines 225490 225532 +42
Branches 42633 42650 +17
=======================================
+ Hits 203072 203125 +53
+ Misses 14193 14188 -5
+ Partials 8225 8219 -6
... and 26 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Ethan-Arrowood
approved these changes
May 15, 2026
Comment thread
test/parallel/test-stream-iter-pipeto-writev.js
Outdated
PushWriter in block backpressure mode can return false from writeSync() and writevSync() after accepting data. Treat that false return as backpressure and wait for drain instead of retrying the same chunks asynchronously. Fixes: nodejs#63296 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-ter-pipeto-write
branch
from
921ab42 to
b04c8c0
Compare
May 15, 2026 17:37
jasnell
approved these changes
May 15, 2026
This comment was marked as outdated.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I'd assumed that CI will wait for a re-review from @Ethan-Arrowood again before attempting to merge. |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
PushWriter in block backpressure mode can return false from writeSync() and writevSync() after accepting data. Treat that false return as backpressure and wait for drain instead of retrying the same chunks asynchronously. Fixes: #63296 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63297 Fixes: #63296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2026
PushWriter in block backpressure mode can return false from writeSync() and writevSync() after accepting data. Treat that false return as backpressure and wait for drain instead of retrying the same chunks asynchronously. Fixes: #63296 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63297 Fixes: #63296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
PushWriter in block backpressure mode can return false from writeSync() and writevSync() after accepting data. Treat that false return as backpressure and wait for drain instead of retrying the same chunks asynchronously. Fixes: nodejs#63296 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63297 Fixes: nodejs#63296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
PushWriter in block backpressure mode can return false from writeSync() and writevSync() after accepting data. Treat that false return as backpressure and wait for drain instead of retrying the same chunks asynchronously. Fixes: #63296 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63297 Backport-PR-URL: #64675 Fixes: #63296 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipeTo() treated writeSync() / writevSync() returning false as a
failed sync write and retried the same chunk(s) through the async path.
That is incorrect for PushWriter with backpressure: 'block', where
false means the data was accepted but the writer is now backpressured. This
caused duplicated output such as abcdcd instead of abcd, and abbb
instead of ab.
This updates pipeTo() to detect that internal writer case and wait for drain
instead of retrying accepted data. It also adds regression coverage for both
the single-chunk writeSync() path and the multi-chunk writevSync() path.
Fixes: #63296
Assisted-by: openai:gpt-5.5