stream: avoid duplicate writes in toWritable - #63360
Merged
nodejs-github-bot merged 2 commits intoMay 23, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 87.14286% with 9 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63360 +/- ##
=======================================
Coverage 90.05% 90.05%
=======================================
Files 714 714
Lines 225704 225768 +64
Branches 42714 42727 +13
=======================================
+ Hits 203250 203321 +71
- Misses 14225 14242 +17
+ Partials 8229 8205 -24
... and 42 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
trivikr
force-pushed
the
stream-iter-towritable-write
branch
from
a03df89 to
52ffb94
Compare
May 16, 2026 15:12
trivikr
force-pushed
the
stream-iter-towritable-write
branch
from
52ffb94 to
7fc1888
Compare
May 17, 2026 15:50
PushWriter can return false after accepting a chunk when block backpressure is active. Teach the classic Writable adapter to treat that case as accepted backpressure instead of retrying through the async write path. Fixes: nodejs#63359 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
stream-iter-towritable-write
branch
from
7fc1888 to
c5132e7
Compare
May 17, 2026 23:38
jasnell
approved these changes
May 22, 2026
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/63360 ✔ Done loading data for nodejs/node/pull/63360 ----------------------------------- PR info ------------------------------------ Title stream: avoid duplicate writes in toWritable (#63360) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch trivikr:stream-iter-towritable-write -> nodejs:main Labels stream, author ready, needs-ci Commits 2 - stream: avoid duplicate writes in toWritable - doc: describe kSyncWriteAcceptedOnFalse stream sentinel Committers 1 - Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/63360 Fixes: https://github.com/nodejs/node/issues/63359 Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/63360 Fixes: https://github.com/nodejs/node/issues/63359 Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 16 May 2026 02:41:57 GMT ✔ Approvals: 1 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/63360#pullrequestreview-4342429217 ✘ This PR needs to wait 13 more hours to land (or 0 minutes if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-05-22T04:50:23Z: https://ci.nodejs.org/job/node-test-pull-request/73613/ - Querying data for job/node-test-pull-request/73613/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/26292186844 |
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
May 27, 2026
PushWriter can return false after accepting a chunk when block backpressure is active. Teach the classic Writable adapter to treat that case as accepted backpressure instead of retrying through the async write path. Fixes: #63359 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63360 Fixes: #63359 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
PushWriter can return false after accepting a chunk when block backpressure is active. Teach the classic Writable adapter to treat that case as accepted backpressure instead of retrying through the async write path. Fixes: nodejs#63359 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63360 Fixes: nodejs#63359 Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
PushWriter can return false after accepting a chunk when block backpressure is active. Teach the classic Writable adapter to treat that case as accepted backpressure instead of retrying through the async write path. Fixes: #63359 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63360 Backport-PR-URL: #64675 Fixes: #63359 Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
toWritable() currently treats writeSync() / writevSync() returning
false as meaning the data was not accepted and retries through the async
writer method.
For PushWriter with backpressure: 'block', false can instead mean the
chunk was accepted and backpressure is active. Retrying through
write() / writev() writes the same data twice.
This updates the adapter to recognize that accepted-backpressure case and wait
for drain instead of retrying the chunk.
Fixes: #63359
Assisted-by: openai:gpt-5.5