test: allow zero min in eventloopdelay histogram - #63387
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The event loop delay histogram can record a zero-valued sample when two successive clock reads observe the same effective time. Keep checking that samples were recorded, but do not require the minimum sample to be positive. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Copy link
Copy Markdown
Member
Author
|
Added request-ci label for #63100, so that it can be merged |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #63387 +/- ##
==========================================
- Coverage 90.06% 90.05% -0.02%
==========================================
Files 714 714
Lines 225629 225648 +19
Branches 42702 42698 -4
==========================================
- Hits 203211 203202 -9
+ Misses 14232 14224 -8
- Partials 8186 8222 +36 see 64 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test-performance-eventloopdelay test can fail intermittently after
recording samples if one event loop delay sample is 0.
HDR histograms allow 0 values, and hdr_min() returns 0 when bucket 0 has
a count. This can happen when two successive uv_hrtime() reads observe the
same effective clock value.
This updates the test to keep requiring recorded samples while allowing
histogram.min to be 0.
Refs: https://github.com/nodejs/reliability/blob/main/reports/2026-05-17.md#jstest-failure
Assisted-by: openai:gpt-5.5