doc: fix promise nomenclature in stream_iter.md - #63406
Merged
aduh95 merged 2 commits intoMay 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Copy link
Copy Markdown
Member
|
The fs.md stream/iter methods are also using the unsupported T<...> syntax: https://github.com/search?q=repo%3Anodejs%2Fnode+path%3A%2F%5Edoc%5C%2Fapi%5C%2F%2F+%2F%5C%7B%5B%5E%7D%5Cs%5D%2B%3C%2F&type=code |
Sorry, something went wrong.
Renegade334
approved these changes
May 18, 2026
lpinca
approved these changes
May 19, 2026
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @aduh95 to include in the upcoming release. Please 👍 to approve. |
Sorry, something went wrong.
aduh95
added a commit
that referenced
this pull request
May 20, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: #63406 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Jul 30, 2026
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#63406 Reviewed-By: René <contact.9a5d6388@renegade334.me.uk> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to https://tc39.es/ecma262/#sec-promise-objects:
Using "resolve" is ambiguous and is not what we actually mean in most cases.