doc: mention crypto.hash() for better perf - #63420
Merged
nodejs-github-bot merged 2 commits intoJul 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
Signed-off-by: Steven <steven@ceriously.com>
styfle
force-pushed
the
styfle/docs-crypto
branch
from
5759172 to
05c7389
Compare
May 19, 2026 01:22
anonrig
approved these changes
May 19, 2026
joyeecheung
reviewed
May 20, 2026
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I feel that we should be less imperative in the docs for performance recommendations, it's better to just state the performance observations and users can decide for themselves considering their input shapes (it's not definitively faster if the data is not readily available).
Sorry, something went wrong.
Comment thread
doc/api/crypto.md
Outdated
Co-authored-by: Joyee Cheung <joyeec9h3@gmail.com>
joyeecheung
approved these changes
May 20, 2026
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM, thanks
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 29, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 6, 2026
Signed-off-by: Steven <steven@ceriously.com> PR-URL: #63420 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The docs on crypto.hash() already mentioned why you would use it over crypto.createHash().
This PR adds the reverse so that the docs on crypto.createHash() mention why you would use crypto.hash().