http2: finish pending writes after stream close - #63439
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
trivikr
force-pushed
the
flaky-test-http2-close-while-writing-2
branch
2 times, most recently
from
2bdb909 to
125b092
Compare
May 19, 2026 19:23
Flush pending Http2Stream write callbacks when nghttp2 closes the stream but JS keeps it alive to finish readable-side cleanup. Also avoid queueing additional writes once the stream is closed. Fixes: nodejs#58252 Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
trivikr
force-pushed
the
flaky-test-http2-close-while-writing-2
branch
from
125b092 to
58e9183
Compare
May 19, 2026 19:40
Copy link
Copy Markdown
Codecov Report❌ Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #63439 +/- ##
=======================================
Coverage 90.06% 90.06%
=======================================
Files 714 714
Lines 225918 225931 +13
Branches 42734 42739 +5
=======================================
+ Hits 203464 203480 +16
- Misses 14232 14233 +1
+ Partials 8222 8218 -4
... and 29 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a race where an HTTP/2 stream can close while writes are still
queued. In that state, pending write callbacks could be left unresolved, which
kept the test process alive until timeout.
The fix completes pending write callbacks when nghttp2 closes the stream and
prevents additional data from being queued once the stream is closed.
The existing regression test now also verifies that all server-side write
callbacks run before the stream closes.
Fixes: #58252
Tested with:
Assisted-by: openai:gpt-5.5