FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: document net Socket server property by Herrtian · Pull Request #63458 · nodejs/node · GitHub

/ node Public

doc: document net Socket server property - #63458

Closed
Herrtian wants to merge 1 commit into
nodejs:mainfrom
Herrtian:doc-net-socket-server
Closed

doc: document net Socket server property#63458
Herrtian wants to merge 1 commit into
nodejs:mainfrom
Herrtian:doc-net-socket-server

Conversation

Copy link
Copy Markdown
Contributor

Fixes: #47148

Documents the net.Socket#server property for sockets accepted by a server.

Validation:

  • node tools/lint-md/lint-md.mjs doc/api/net.md
  • git diff --check

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/net

nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels May 20, 2026

Copy link
Copy Markdown
Member

@Herrtian The commit message check is failing here because there's no Signed-off-by line in the commit message. See the commit message guidelines. You'll need to run git commit --amend -s to sign the existing commit, and then force push to update it here.

Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

Signed off and pushed, thanks.

pimterry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Perfect, thanks @Herrtian! This has to wait a little bit for the minimum time before merging, but then I think it's ready to go.

pimterry added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label May 21, 2026
Herrtian closed this by deleting the head repository May 21, 2026
efekrskl added a commit to efekrskl/node that referenced this pull request Jul 8, 2026
Based on nodejs#63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
nodejs-github-bot pushed a commit that referenced this pull request Jul 13, 2026
Based on #63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
PR-URL: #64364
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Based on #63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
PR-URL: #64364
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Jul 21, 2026
Based on #63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
PR-URL: #64364
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Jul 29, 2026
Based on #63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
PR-URL: #64364
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
Based on #63458.

Co-authored-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
Signed-off-by: Efe Karasakal <hi@efe.dev>
Signed-off-by: Herrtian <70463940+Herrtian@users.noreply.github.com>
PR-URL: #64364
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing reference (and types) for response.socket.server

4 participants


Back | FazBrowse Home | New Git URL